sysutils/intel-undervolt/Makefile
6	I think this is fine, see Example 5.14. Using USE_GITHUB to Access a Commit Between Two Versions in the Porter's Handbook.
24	I think that we should use `@sample` here (see 8.6.9. @sample file [file] in the Porter's Handbook).

val_packett.cool added inline comments.Jan 4 2019, 5:50 PM

sysutils/intel-undervolt/Makefile
6	Yeah, I always thought of `DISTVERSIONSUFFIX=-gWHATEVER` as a "higher level" wrapper around `GH_TAGNAME`
24	Do the `@` things work with `PLIST_FILES` (w/o dedicated `pkg-plist` file)?

0mp added inline comments.Jan 9 2019, 10:22 AM

sysutils/intel-undervolt/Makefile
24	AFAIR, yes.

tobik added a subscriber: tobik.Jan 9 2019, 10:33 AM

tobik added inline comments.

sysutils/intel-undervolt/Makefile
21	Why `+=`?
24	Yes, of course. PLIST_FILES is basically just appended to TMPPLIST. Just make sure to quote the entry like `"@sample etc/intel-undervolt.conf.sample"`, so that make(1) treats it as a single word and it's added as one line to it.

Updated with suggestions

val_packett.cool marked 6 inline comments as done.Jan 9 2019, 7:34 PM

linimon retitled this revision from New port: sysutils/intel-undervolt to New port: sysutils/intel-undervolt: Intel CPU undervolting tool.Jan 15 2019, 4:23 PM

This looks ok.

This revision is now accepted and ready to land.Jan 20 2019, 1:38 PM

Closed by commit rP491250: New port: sysutils/intel-undervolt (authored by tobik). · Explain WhyJan 26 2019, 8:25 AM

This revision was automatically updated to reflect the committed changes.

@greg_unrelenting.technology Committed. Thanks!

As a general rule, it's better if you also submit a bug on https://bugs.freebsd.org for new ports and updates, so that things can be tracked better. Bugzilla is also where more committers look for things to commit.