Add ofw_bus_find_compatible to find a compatible child node.
ClosedPublic
Actions

Authored by andrew on Apr 30 2015, 8:47 PM.

Details

Reviewers

nwhitehorn
andrew
imp

Group Reviewers

manpages

Summary

This will be used to search for a node before device_t's are available,
e.g. to get the registers to enable secondary cores.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

andrew updated this revision to Diff 5122.Apr 30 2015, 8:47 PM

andrew retitled this revision from to Add ofw_bus_find_compatible to find a compatible child node..

andrew updated this object.

andrew edited the test plan for this revision. (Show Details)

andrew added reviewers: imp, nwhitehorn.

Herald added a reviewer: manpages. · View Herald TranscriptApr 30 2015, 8:47 PM

Herald added a subscriber: imp. · View Herald Transcript

jpa-semihalf.com added a subscriber: jpa-semihalf.com.May 7 2015, 11:03 AM

andrew accepted this revision.May 11 2015, 2:12 PM

andrew added a reviewer: andrew.

This revision is now accepted and ready to land.May 11 2015, 2:12 PM

https://svnweb.freebsd.org/changeset/base/282770

Hi, thank you for adding the functionality, btw could you also send the header? It is missing in the commit.

zbb edited edge metadata.May 12 2015, 2:34 PM

zbb added a subscriber: emaste.

Hi,
I have two concerns regarding this issue:

the commit to the repository you made is different than the code in this review
there is a bug in the commit in ofw_bus_find_compatible():

OF_getprop_alloc shall be called with child instead of node. Could you fix it plesase?

Revision Contents
Changeset List

Path

Size

sys/

dev/

ofw/

ofw_bus_subr.h

3 lines

ofw_bus_subr.c

61 lines

Diff 5122

View Options

sys/dev/ofw/ofw_bus_subr.h