Page MenuHomeFreeBSD

jpa-semihalf.com (Jakub Palider)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 18 2015, 12:27 PM (239 w, 1 d)

Recent Activity

Sep 7 2016

jpa-semihalf.com abandoned D5190: Network driver support for Alpine platform.

This thread is no longer active, it has been moved to a reworked to reflect current FreeBSD mechanisms and is to be found in D7814

Sep 7 2016, 3:25 PM

Sep 6 2016

jpa-semihalf.com added a comment to D5190: Network driver support for Alpine platform.

We have reworked the driver a bit once we finish sanity checks the newer version will appear here, or, if the changes happen to be too big, this issue will be abandoned with proper link to an update. ETA: today/tomorrow, once the HEAD gets back to normal.

Sep 6 2016, 2:19 PM

Aug 19 2016

jpa-semihalf.com abandoned D2579: PCI support for Alpine platform from Annapurna Labs.
Aug 19 2016, 4:14 PM
jpa-semihalf.com updated D2579: PCI support for Alpine platform from Annapurna Labs.
Aug 19 2016, 4:14 PM

Apr 5 2016

jpa-semihalf.com added a comment to D2579: PCI support for Alpine platform from Annapurna Labs.

Anyone?

Apr 5 2016, 12:53 PM

Apr 1 2016

jpa-semihalf.com updated the diff for D2579: PCI support for Alpine platform from Annapurna Labs.

This is yet another version, which takes into consideration other Alpine platforms.

Apr 1 2016, 2:41 PM
jpa-semihalf.com updated the diff for D2579: PCI support for Alpine platform from Annapurna Labs.

It looks things went forward - the D4879 got into mainline. There are no dependencies left, may I ask you for your review, then?

Apr 1 2016, 9:53 AM

Mar 31 2016

jpa-semihalf.com reopened D4301: Disable MSI-x for AHCI on Alpine plattform.
Mar 31 2016, 9:06 AM
jpa-semihalf.com updated the diff for D4301: Disable MSI-x for AHCI on Alpine plattform.

Since other changes slipped in-between it would be cleaner to resubmit a new version. Plus following @mav suggestion on putting it at the end

Mar 31 2016, 9:06 AM

Feb 4 2016

jpa-semihalf.com added a comment to D4879: OFW PCI code decuplications - involves ARM, PPC and SPARC64.

Anyone would like to share a comment on this? There are a few pending commits blocked by this one...

Feb 4 2016, 1:26 PM
jpa-semihalf.com added a comment to D4879: OFW PCI code decuplications - involves ARM, PPC and SPARC64.
Feb 4 2016, 1:23 PM
jpa-semihalf.com retitled D5190: Network driver support for Alpine platform from to Network driver support for Alpine platform.
Feb 4 2016, 1:20 PM

Feb 2 2016

jpa-semihalf.com updated the diff for D4879: OFW PCI code decuplications - involves ARM, PPC and SPARC64.

Add implementation of new bus_get_bus_tag(). This is required for archs where child bus tag differs from parent's one (another endianess).
There are added methods in some platforms nexus.c files which return platform specific default tag and ofw_pci_bus_get_bus_tag() in dev/ofw/ofw_pci.c for PowerPC which return correct tag.

Feb 2 2016, 3:24 PM

Jan 27 2016

jpa-semihalf.com closed D4301: Disable MSI-x for AHCI on Alpine plattform.
Jan 27 2016, 2:03 PM
jpa-semihalf.com closed D2340: Support for Alpine platform from Annapurna Labs.
Jan 27 2016, 2:03 PM
jpa-semihalf.com closed D2438: ARM CP15 operations for db show command.
Jan 27 2016, 11:19 AM

Jan 22 2016

jpa-semihalf.com added inline comments to D4879: OFW PCI code decuplications - involves ARM, PPC and SPARC64.
Jan 22 2016, 12:05 PM

Jan 19 2016

jpa-semihalf.com updated the diff for D4879: OFW PCI code decuplications - involves ARM, PPC and SPARC64.

This diff just ports the ofw_pci stuff, taking into consideration the recent changes in PPC files (r294277). This shall be a good starting point for further modifications - I hope I omitted nothing from the discussion conclusions.

Jan 19 2016, 11:40 AM

Jan 18 2016

jpa-semihalf.com added inline comments to D4879: OFW PCI code decuplications - involves ARM, PPC and SPARC64.
Jan 18 2016, 2:21 PM

Jan 15 2016

jpa-semihalf.com updated the diff for D4879: OFW PCI code decuplications - involves ARM, PPC and SPARC64.

As previously suggested this diff includes move from ppc ofw code into sys ofw, which is a desired transition regardless on additional changes. It also includes changes in _nranges() function which is desired in our platform code. That implied some minor changes in header. Could you please comment starting from this revison?

Jan 15 2016, 1:48 PM

Jan 13 2016

jpa-semihalf.com added a comment to D4879: OFW PCI code decuplications - involves ARM, PPC and SPARC64.

In our code it would be convenient and elegant to have some cell attributes kept aside and use at a later stage - this is done in ofw_pci_nranges(). Moving the files to have everything shared is a good idea, but some changes are needed while the transition. It could be done in two runs (move the code, and then update for our needs) but taking the changes are slight I would rather merge them into one commit.

Jan 13 2016, 5:37 PM
jpa-semihalf.com added a comment to D4879: OFW PCI code decuplications - involves ARM, PPC and SPARC64.

As for the fdt header I looks it is remaining not cleaned up. Shall not appear at this stage.
Moving it as is would conflict with what we expected from its functionality, and would need to copy&paste&modify the code, just in another directory. Slightly extending the functionality gives what is needed in ARM code, not really conflicting PPC flow.

Jan 13 2016, 10:09 AM

Jan 12 2016

jpa-semihalf.com added a comment to D4301: Disable MSI-x for AHCI on Alpine plattform.

Any comments on this? Unless you have objections I would be happy to have it commited.

Jan 12 2016, 11:23 AM
jpa-semihalf.com updated the diff for D2579: PCI support for Alpine platform from Annapurna Labs.

This is an update version, with fixes applied + uses the common code to be found in D4879: OFW PCI code decuplications - involves ARM, PPC and SPARC64

Jan 12 2016, 11:20 AM
jpa-semihalf.com retitled D4879: OFW PCI code decuplications - involves ARM, PPC and SPARC64 from to OFW PCI code decuplications - involves ARM and PPC.
Jan 12 2016, 11:17 AM

Dec 1 2015

jpa-semihalf.com updated the diff for D2579: PCI support for Alpine platform from Annapurna Labs.

Filled missing options that were added.

Dec 1 2015, 5:10 PM
jpa-semihalf.com added a comment to D4301: Disable MSI-x for AHCI on Alpine plattform.

Fixing it would mean digging into bootloader code, so I'd rather steer clear of it. We are not going to use the MSI-x extenstion on this board.

Dec 1 2015, 11:32 AM

Nov 27 2015

jpa-semihalf.com retitled D4301: Disable MSI-x for AHCI on Alpine plattform from to Disable MSI-x for AHCI on Alpine plaftrorm.
Nov 27 2015, 11:57 AM

Nov 23 2015

jpa-semihalf.com updated D2579: PCI support for Alpine platform from Annapurna Labs.
Nov 23 2015, 11:28 AM
jpa-semihalf.com updated the diff for D2579: PCI support for Alpine platform from Annapurna Labs.

This is an updated version of previous drop, and addresses comments from previous review.
Additionally, it adds MSI-x support, because during discussion it turned out that this is a cleaner way.

Nov 23 2015, 11:26 AM
jpa-semihalf.com added inline comments to D2579: PCI support for Alpine platform from Annapurna Labs.
Nov 23 2015, 10:59 AM

Aug 17 2015

jpa-semihalf.com updated the diff for D1810: Leave HYP mode upon startup.

Fixed #ifdef mess.

Aug 17 2015, 10:46 AM

Aug 13 2015

jpa-semihalf.com added a comment to D1810: Leave HYP mode upon startup.

Anyone? ACK/NACK?

Aug 13 2015, 3:49 PM

Aug 11 2015

jpa-semihalf.com updated the diff for D1810: Leave HYP mode upon startup.

This is yet another revision of this patch, after out-of-band discussion with Warner, so should be much closer to a final version.

Aug 11 2015, 3:39 PM

Aug 4 2015

jpa-semihalf.com added inline comments to D1810: Leave HYP mode upon startup.
Aug 4 2015, 8:59 AM

Aug 3 2015

jpa-semihalf.com updated the diff for D1810: Leave HYP mode upon startup.

This is a polished version of previous commit:

  • the check for binutils is based on clang variable which is more reliable.
  • code duplication removal
  • ensuring that interrupts are disabled on mode change
Aug 3 2015, 8:18 AM
jpa-semihalf.com commandeered D1810: Leave HYP mode upon startup.
Aug 3 2015, 8:13 AM

Jul 30 2015

jpa-semihalf.com added inline comments to D1833: Add memory barriers to buf_ring.
Jul 30 2015, 3:05 PM
jpa-semihalf.com retitled D3248: Remove files from sys/arm directory from to Remove files from sys/arm directory.
Jul 30 2015, 10:16 AM

May 20 2015

jpa-semihalf.com added inline comments to D2579: PCI support for Alpine platform from Annapurna Labs.
May 20 2015, 8:00 AM

May 19 2015

jpa-semihalf.com added inline comments to D2579: PCI support for Alpine platform from Annapurna Labs.
May 19 2015, 3:22 PM
jpa-semihalf.com added inline comments to D2579: PCI support for Alpine platform from Annapurna Labs.
May 19 2015, 3:02 PM
jpa-semihalf.com retitled D2579: PCI support for Alpine platform from Annapurna Labs from to PCI support for Alpine platform from Annapurna Labs.
May 19 2015, 9:28 AM

May 14 2015

jpa-semihalf.com updated the diff for D2340: Support for Alpine platform from Annapurna Labs.

Removed spare dmb() in favor to dsb() only. That change in hal appeared when fixing compilation errors after extracting PCI.

May 14 2015, 3:52 PM
jpa-semihalf.com added inline comments to D2340: Support for Alpine platform from Annapurna Labs.
May 14 2015, 3:49 PM
jpa-semihalf.com updated the diff for D2340: Support for Alpine platform from Annapurna Labs.

This version is without PCI support - that will appear in a separate review.

May 14 2015, 2:46 PM
jpa-semihalf.com updated the diff for D2340: Support for Alpine platform from Annapurna Labs.

Thank you for discussion and suggestions. This revision fixes reported style + a bit more.
As for the discussion topics, a roadmap with regard to mentioned issues looks like this:

  1. delivery the platform support as is - this is a coherent change in terms of platform and hal
  2. the next planned code drop involves msix support so relates to pci enhancement and cleanup. At this stage I will deal with dts compatibility - this will let me parallelise some works.
  3. meanwhile, I will move the hal to sys/contrib. This shall be a painless transition and will prelude another hal drop in for eth driver

Does it sound reasonable?

May 14 2015, 9:46 AM
jpa-semihalf.com added a comment to D2340: Support for Alpine platform from Annapurna Labs.
May 14 2015, 9:27 AM

May 12 2015

jpa-semihalf.com added inline comments to D2340: Support for Alpine platform from Annapurna Labs.
May 12 2015, 4:25 PM
jpa-semihalf.com updated the diff for D2340: Support for Alpine platform from Annapurna Labs.

This revision addresses all your pointers. I hope all problems are solved now.

May 12 2015, 3:10 PM
jpa-semihalf.com added a comment to D2416: Add ofw_bus_find_compatible to find a compatible child node..

Hi,
I have two concerns regarding this issue:

  1. the commit to the repository you made is different than the code in this review
  2. there is a bug in the commit in ofw_bus_find_compatible():

OF_getprop_alloc shall be called with child instead of node. Could you fix it plesase?

May 12 2015, 2:36 PM
jpa-semihalf.com added inline comments to D2340: Support for Alpine platform from Annapurna Labs.
May 12 2015, 10:09 AM

May 11 2015

jpa-semihalf.com commandeered D1833: Add memory barriers to buf_ring.
May 11 2015, 5:04 PM
jpa-semihalf.com commandeered D1945: Buf ring cleanups.
May 11 2015, 5:01 PM
jpa-semihalf.com added a comment to D1810: Leave HYP mode upon startup.

Does anyone has objections to this version?

May 11 2015, 4:36 PM
jpa-semihalf.com added a comment to D2416: Add ofw_bus_find_compatible to find a compatible child node..

Hi, thank you for adding the functionality, btw could you also send the header? It is missing in the commit.

May 11 2015, 3:39 PM

May 6 2015

jpa-semihalf.com updated the diff for D2438: ARM CP15 operations for db show command.

Thank you for previous comments. Here is updated diff, I hope it is fine now.

May 6 2015, 9:46 AM
jpa-semihalf.com added a comment to D2438: ARM CP15 operations for db show command.

Right, sorry for the mess with the #ifdefs, fixing it.

May 6 2015, 8:32 AM

May 4 2015

jpa-semihalf.com retitled D2438: ARM CP15 operations for db show command from to ARM CP15 operations for db show command.
May 4 2015, 2:31 PM
jpa-semihalf.com added inline comments to D2340: Support for Alpine platform from Annapurna Labs.
May 4 2015, 11:53 AM
jpa-semihalf.com added inline comments to D2340: Support for Alpine platform from Annapurna Labs.
May 4 2015, 11:43 AM

Apr 30 2015

jpa-semihalf.com added inline comments to D2340: Support for Alpine platform from Annapurna Labs.
Apr 30 2015, 4:05 PM

Apr 29 2015

jpa-semihalf.com added inline comments to D2340: Support for Alpine platform from Annapurna Labs.
Apr 29 2015, 8:53 AM

Apr 28 2015

jpa-semihalf.com updated the diff for D2340: Support for Alpine platform from Annapurna Labs.

Thank you all for your feedback. Unless answered to the remarks, I followed your recommendations, which results in the second version. Please, have a look at this.

Apr 28 2015, 7:53 AM
jpa-semihalf.com added inline comments to D2340: Support for Alpine platform from Annapurna Labs.
Apr 28 2015, 7:10 AM

Apr 23 2015

jpa-semihalf.com added a comment to D2340: Support for Alpine platform from Annapurna Labs.
In D2340#42671, @onwahe-gmail-com wrote:

Was this tested with ARM_NEW_PMAP option?

Apr 23 2015, 8:55 AM

Apr 21 2015

jpa-semihalf.com retitled D2340: Support for Alpine platform from Annapurna Labs from to Support for Alpine platform from Annapurna Labs.
Apr 21 2015, 1:57 PM

Mar 26 2015

jpa-semihalf.com added a comment to D1945: Buf ring cleanups.

I see there was huge amount of good work put into fixing the race, fruitful discussion, but also no updates since last month. Frankly speaking, I am waiting to see this fix in mainline, instead of using patch from with Wojciech Macek. Are there any more issues with this or can it be merged?

Mar 26 2015, 11:36 AM

Mar 20 2015

jpa-semihalf.com added a comment to D1810: Leave HYP mode upon startup.

Do you have any concerns regarding these changes? If so, please, let me know.
There is one issue still not solved - current gcc version probably will not be able to handle that. Do we really care?

Mar 20 2015, 10:06 AM

Mar 19 2015

jpa-semihalf.com added a comment to D1903: Allow setting kernbase on ARM.

Seems this thread has stalled a bit. May I ask you for some input regarding this change? The conclusion at this state is that we want keep just one identifier, that is KERNBASE, and do not want a system-wide change, at least now. The drawback of currest proposal that this feature would be arm-related, but taking into consideration the usage diversity of arm-based devices, that would not be unusual. As I pointed out,there are #ifndefs already existing in arm's vmparam.h so this change would be merely an extension to the present scheme. What do you think?

Mar 19 2015, 12:25 PM