Differential D4301

Disable MSI-x for AHCI on Alpine plattform
ClosedPublic
Actions

Authored by jpa-semihalf.com on Nov 27 2015, 11:57 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Nov 25, 1:22 AM

	Unknown Object (File)
	Fri, Nov 22, 7:02 PM

	Unknown Object (File)
	Thu, Nov 21, 4:56 PM

	Unknown Object (File)
	Mon, Nov 18, 3:36 PM

	Unknown Object (File)
	Thu, Nov 7, 4:24 AM

	Unknown Object (File)
	Thu, Nov 7, 1:18 AM

	Unknown Object (File)
	Wed, Nov 6, 6:26 AM

	Unknown Object (File)
	Wed, Nov 6, 2:14 AM

View All 84 Files

Subscribers

freebsd-arm-list

Details

Reviewers

zbb
andrew
imp
mav

Commits

rS297447: Disable MSI-x for AHCI on Alpine plattform

Summary

Changes introduced to AHCI code adding support for MSI-x caused interrupt storm on Alpine boards. This is unintended behaviour so added quirk to omit this functionality. This is a small and non-intrusive patch so I hope no problems will arise, anyway, have a look at this, please.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jpa-semihalf.com updated this revision to Diff 10542.Nov 27 2015, 11:57 AM

jpa-semihalf.com retitled this revision from to Disable MSI-x for AHCI on Alpine plaftrorm.

jpa-semihalf.com updated this object.

jpa-semihalf.com edited the test plan for this revision. (Show Details)

jpa-semihalf.com added reviewers: imp, andrew, zbb.

jpa-semihalf.com added a subscriber: freebsd-arm-list.

pi retitled this revision from Disable MSI-x for AHCI on Alpine plaftrorm to Disable MSI-x for AHCI on Alpine plattform.Nov 30 2015, 6:17 AM

andrew added a reviewer: mav.Nov 30 2015, 9:42 AM

I have no objections, but can't this MSI-X functionality be fixed instead of disabling? Or it is know to be completely broken?

Fixing it would mean digging into bootloader code, so I'd rather steer clear of it. We are not going to use the MSI-x extenstion on this board.

emaste added a subscriber: emaste.Dec 8 2015, 7:59 PM

Any comments on this? Unless you have objections I would be happy to have it commited.

I would just probably added new quirk to the end of the list instead of renumbering others.

This revision is now accepted and ready to land.Jan 12 2016, 3:24 PM

jpa-semihalf.com closed this revision.Jan 27 2016, 2:03 PM

Since other changes slipped in-between it would be cleaner to resubmit a new version. Plus following @mav suggestion on putting it at the end

jpa-semihalf.com reopened this revision.Mar 31 2016, 9:06 AM

I have no objections.

This revision is now accepted and ready to land.Mar 31 2016, 9:26 AM

Closed by commit rS297447: Disable MSI-x for AHCI on Alpine plattform (authored by zbb). · Explain WhyMar 31 2016, 11:19 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

ahci/

4 lines

5 lines

Diff 14785

head/sys/dev/ahci/ahci.h

Loading...

head/sys/dev/ahci/ahci_pci.c

Loading...