Page MenuHomeFreeBSD
Differential D17981

arm64 pmap: Handle kernel mappings in pmap_remove_l2().
ClosedPublic
Actions

Authored by markj on Nov 13 2018, 7:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 14, 9:24 AM
Unknown Object (File)
Wed, Nov 13, 12:05 AM
Unknown Object (File)
Tue, Nov 12, 4:05 PM
Unknown Object (File)
Mon, Nov 11, 12:06 PM
Unknown Object (File)
Sun, Nov 10, 5:24 PM
Unknown Object (File)
Oct 24 2024, 6:47 PM
Unknown Object (File)
Oct 23 2024, 2:09 AM
Unknown Object (File)
Sep 21 2024, 5:34 AM
View All 83 Files
Subscribers
andrew
emaste
imp

Details

Reviewers
manu
andrew
alc
kib
Commits
rS340678: Handle kernel superpage mappings in pmap_remove_l2().
Test Plan

Only compile-tested so far.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20805
Build 20199: arc lint + arc unit

Event Timeline

markj created this revision.Nov 13 2018, 7:24 PM
Herald added a reviewer: manu. · View Herald TranscriptNov 13 2018, 7:24 PM
Herald added subscribers: emaste, andrew. · View Herald Transcript
Harbormaster completed remote builds in B20794: Diff 50378.Nov 13 2018, 7:24 PM
markj updated this revision to Diff 50380.Nov 13 2018, 7:59 PM
  • Ensure that the existing mapping was destroyed.
Harbormaster completed remote builds in B20795: Diff 50380.Nov 13 2018, 7:59 PM
markj updated this revision to Diff 50383.Nov 13 2018, 8:26 PM
  • Fix KASSERT() format string.
Harbormaster completed remote builds in B20797: Diff 50383.Nov 13 2018, 8:26 PM
markj edited the test plan for this revision. (Show Details)Nov 13 2018, 8:27 PM
markj added reviewers: andrew, alc, kib.
kib added inline comments.Nov 14 2018, 7:48 AM
sys/arm64/arm64/pmap.c
2412

This is the 'break before make', right ? Might be mention the term in the comment above ?

So what would happen with the parallel accesses to the l2 range meantime ?

2418

... or kernel.

markj marked 3 inline comments as done.Nov 14 2018, 4:33 PM
markj added inline comments.
sys/arm64/arm64/pmap.c
2412

Right, the "break" happens in pmap_remove_l2(). I'll update the comment here.

I believe it will cause a data abort. As we discussed in email, I believe this can already happen with pmap_demote_l2(). My intent here is to fix the problem with superpages in exec_map, which is pageable.

markj updated this revision to Diff 50419.Nov 14 2018, 4:33 PM
markj marked an inline comment as done.
  • Address kib's feedback.
Harbormaster completed remote builds in B20805: Diff 50419.Nov 14 2018, 4:33 PM
kib accepted this revision.Nov 14 2018, 8:10 PM
This revision is now accepted and ready to land.Nov 14 2018, 8:10 PM
alc added inline comments.Nov 15 2018, 5:07 AM
sys/arm64/arm64/pmap.c
2401

I think that this should just be

newl2 = ml3pa | L2_TABLE;
alc accepted this revision.Nov 15 2018, 5:11 AM

Aside from my one comment, this looks fine. Once that comment is addressed, consider this change "Accepted" by me.

andrew accepted this revision.Nov 15 2018, 2:42 PM
andrew added inline comments.
sys/arm64/arm64/pmap.c
2401

Yes. ATTR_DEFAULT and ATTR_IDX are only needed on last level entries. The bits they set are ignored on table entries.

markj updated this revision to Diff 50450.Nov 15 2018, 5:24 PM
  • Remove flags that don't make sense for a table descriptor.
This revision now requires review to proceed.Nov 15 2018, 5:24 PM
Harbormaster completed remote builds in B20823: Diff 50450.Nov 15 2018, 5:24 PM
andrew accepted this revision.Nov 15 2018, 5:25 PM
This revision is now accepted and ready to land.Nov 15 2018, 5:25 PM
alc accepted this revision.Nov 15 2018, 9:51 PM
Closed by commit rS340678: Handle kernel superpage mappings in pmap_remove_l2(). (authored by markj). · Explain WhyNov 20 2018, 3:12 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptNov 20 2018, 3:12 PM

Revision Contents
Changeset List

PathSize
sys/
arm64/
arm64/
56 lines

Diff 50419

View Options

sys/arm64/arm64/pmap.c

Loading...