Page MenuHomeFreeBSD

Use tcp_state_change() in the cxgbe(4) TOE module.
ClosedPublic

Authored by jhb on Nov 9 2018, 12:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 26, 8:59 PM
Unknown Object (File)
Tue, Nov 26, 1:54 PM
Unknown Object (File)
Sun, Nov 24, 3:38 AM
Unknown Object (File)
Mon, Nov 11, 9:43 AM
Unknown Object (File)
Oct 29 2024, 4:22 PM
Unknown Object (File)
Sep 28 2024, 4:43 AM
Unknown Object (File)
Sep 27 2024, 8:20 AM
Unknown Object (File)
Sep 26 2024, 2:55 PM
Subscribers

Details

Summary

r254889 added tcp_state_change() as a centralized place to log state
changes in TCP connections for DTrace. r294869 and r296881 took
advantage of this central location to manage per-state counters.
However, TOE sockets were still performing some (but not all) state
change updates via direct assignments to t_state. This resulted in
state counters underflowing when TOE was in use. Fix by using
tcp_state_change() when changing a TOE connection's state.

Test Plan
  • run netstat -s -p tcp while TOE is in use

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20714
Build 20125: arc lint + arc unit