Page MenuHomeFreeBSD

Use tcp_state_change() in the cxgbe(4) TOE module.
ClosedPublic

Authored by jhb on Nov 9 2018, 12:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 15, 8:20 PM
Unknown Object (File)
Jan 16 2025, 1:12 AM
Unknown Object (File)
Dec 19 2024, 10:00 AM
Unknown Object (File)
Dec 2 2024, 7:26 AM
Unknown Object (File)
Nov 26 2024, 8:59 PM
Unknown Object (File)
Nov 26 2024, 1:54 PM
Unknown Object (File)
Nov 24 2024, 3:38 AM
Unknown Object (File)
Nov 11 2024, 9:43 AM
Subscribers

Details

Summary

r254889 added tcp_state_change() as a centralized place to log state
changes in TCP connections for DTrace. r294869 and r296881 took
advantage of this central location to manage per-state counters.
However, TOE sockets were still performing some (but not all) state
change updates via direct assignments to t_state. This resulted in
state counters underflowing when TOE was in use. Fix by using
tcp_state_change() when changing a TOE connection's state.

Test Plan
  • run netstat -s -p tcp while TOE is in use

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20714
Build 20125: arc lint + arc unit