freebsd-update src component skip if not installed
ClosedPublic
Actions

Authored by kczekirda on Apr 24 2015, 6:45 PM.

Details

Reviewers

Group Reviewers

manpages

Summary

if /usr/src is empty skip src component

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

kczekirda retitled this revision from to freebsd-update src component skip if not installed.

kczekirda updated this object.

kczekirda edited the test plan for this revision. (Show Details)

kczekirda changed the visibility from "Public (No Login Required)" to "kczekirda (Kamil Czekirda)".

kczekirda changed the visibility from "kczekirda (Kamil Czekirda)" to "Public (No Login Required)".

delphij requested changes to this revision.Apr 27 2015, 8:49 PM

delphij edited edge metadata.

delphij added inline comments.

head/usr.sbin/freebsd-update/freebsd-update.sh
219	This is really hacky and I don't like it (although I can live with it if it's necessary evil), do we absolutely have no alternatives of hardcoding knowledge about 'src'? By the way, the negation here is unnecessary and confusing. Please reorganize the code so that ! is not used.
222	If we must hardcode /usr/src knowledge, can't we just use if [ -e /usr/src/COPYRIGHT ] instead of a full ls -A?