Page MenuHomeFreeBSD
Differential D17146

ps(1): Add a standard exit status section.
ClosedPublic
Actions

Authored by 0mp on Sep 13 2018, 7:41 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 19, 2:23 AM
Unknown Object (File)
Thu, Feb 27, 4:55 PM
Unknown Object (File)
Sat, Feb 22, 4:39 PM
Unknown Object (File)
Sat, Feb 22, 9:26 AM
Unknown Object (File)
Sat, Feb 22, 2:50 AM
Unknown Object (File)
Fri, Feb 21, 11:12 PM
Unknown Object (File)
Wed, Feb 19, 9:20 PM
Unknown Object (File)
Feb 10 2025, 6:42 PM
View All 96 Files
Subscribers
imp
jilles
krion
mat

Details

Reviewers
bcr
eadler
krion
mat
Group Reviewers
manpages
Commits
rS339957: ps(1): Add a standard exit status section

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

0mp created this revision.Sep 13 2018, 7:41 AM
Herald added a reviewer: manpages. · View Herald TranscriptSep 13 2018, 7:41 AM
Herald added a subscriber: imp. · View Herald Transcript
Harbormaster completed remote builds in B19559: Diff 47984.Sep 13 2018, 7:41 AM
bcr accepted this revision.Sep 13 2018, 9:30 AM

Approved, thanks for working on it.

This revision is now accepted and ready to land.Sep 13 2018, 9:30 AM
0mp added reviewers: krion, mat.Sep 15 2018, 10:58 PM
0mp added subscribers: krion, mat.

@mat, @krion, may I have your approval?

eadler accepted this revision.Sep 15 2018, 11:53 PM
krion accepted this revision.Sep 16 2018, 7:39 AM
jilles added a subscriber: jilles.Sep 16 2018, 1:41 PM

This is not wrong, but perhaps some details about different types of errors may be helpful, such as that nonexistent usernames in -U are immediately fatal while an empty result (such as from only nonexistent process IDs in -p or only existing users that do not currently run any process in -U) still writes the header line (if not disabled) and also returns a non-zero exit status.

Closed by commit rS339957: ps(1): Add a standard exit status section (authored by 0mp). · Explain WhyOct 31 2018, 4:10 PM
This revision was automatically updated to reflect the committed changes.
0mp added a comment.Oct 31 2018, 4:12 PM

@jilles do you think we could open another PR for your suggestions?

In D17146#366362, @jilles wrote:

This is not wrong, but perhaps some details about different types of errors may be helpful, such as that nonexistent usernames in -U are immediately fatal while an empty result (such as from only nonexistent process IDs in -p or only existing users that do not currently run any process in -U) still writes the header line (if not disabled) and also returns a non-zero exit status.

I've created a PR for this: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=232852

0mp mentioned this in rS358942: MFC r339957:.Mar 13 2020, 9:07 AM
0mp mentioned this in rS358943: MFC r339957:.

Revision Contents
Changeset List

PathSize
head/
bin/
ps/
4 lines

Diff 49830

View Options

head/bin/ps/ps.1

Show First 20 Lines • Show All 764 Lines • ▼ Show 20 Lines#endif
if (cio->num_matches >= ionum) { if (cio->num_matches >= ionum) {
error = 0; error = 0;
break; break;
} }
#ifdef PRE7_COMPAT #ifdef PRE7_COMPAT
#ifdef COMPAT_FREEBSD32 #ifdef COMPAT_FREEBSD32
if (cmd == PCIOCGETCONF_OLD32) { if (cmd == PCIOCGETCONF_OLD32) {
memset(&conf_old32, 0,
sizeof(conf_old32));
conf_old32.pc_sel.pc_bus = conf_old32.pc_sel.pc_bus =
dinfo->conf.pc_sel.pc_bus; dinfo->conf.pc_sel.pc_bus;
conf_old32.pc_sel.pc_dev = conf_old32.pc_sel.pc_dev =
dinfo->conf.pc_sel.pc_dev; dinfo->conf.pc_sel.pc_dev;
conf_old32.pc_sel.pc_func = conf_old32.pc_sel.pc_func =
dinfo->conf.pc_sel.pc_func; dinfo->conf.pc_sel.pc_func;
conf_old32.pc_hdr = dinfo->conf.pc_hdr; conf_old32.pc_hdr = dinfo->conf.pc_hdr;
conf_old32.pc_subvendor = conf_old32.pc_subvendor =
Show All 17 Lines#ifdef COMPAT_FREEBSD32
sizeof(conf_old32.pd_name)); sizeof(conf_old32.pd_name));
conf_old32.pd_name[PCI_MAXNAMELEN] = 0; conf_old32.pd_name[PCI_MAXNAMELEN] = 0;
conf_old32.pd_unit = conf_old32.pd_unit =
(uint32_t)dinfo->conf.pd_unit; (uint32_t)dinfo->conf.pd_unit;
confdata = &conf_old32; confdata = &conf_old32;
} else } else
#endif /* COMPAT_FREEBSD32 */ #endif /* COMPAT_FREEBSD32 */
if (cmd == PCIOCGETCONF_OLD) { if (cmd == PCIOCGETCONF_OLD) {
memset(&conf_old, 0, sizeof(conf_old));
conf_old.pc_sel.pc_bus = conf_old.pc_sel.pc_bus =
dinfo->conf.pc_sel.pc_bus; dinfo->conf.pc_sel.pc_bus;
conf_old.pc_sel.pc_dev = conf_old.pc_sel.pc_dev =
dinfo->conf.pc_sel.pc_dev; dinfo->conf.pc_sel.pc_dev;
conf_old.pc_sel.pc_func = conf_old.pc_sel.pc_func =
dinfo->conf.pc_sel.pc_func; dinfo->conf.pc_sel.pc_func;
conf_old.pc_hdr = dinfo->conf.pc_hdr; conf_old.pc_hdr = dinfo->conf.pc_hdr;
conf_old.pc_subvendor = conf_old.pc_subvendor =
▲ Show 20 Lines • Show All 210 Lines • Show Last 20 Lines