Page MenuHomeFreeBSD
Differential D17686

efivar(3): Fix some typos and improve style
ClosedPublic
Actions

Authored by 0mp on Oct 24 2018, 3:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 9, 8:39 AM
Unknown Object (File)
Fri, Oct 9, 7:45 AM
Unknown Object (File)
Fri, Oct 9, 2:25 AM
Unknown Object (File)
Wed, Sep 23, 5:21 PM
Unknown Object (File)
Sun, Sep 20, 12:59 AM
Unknown Object (File)
Sep 8 2026, 8:43 PM
Unknown Object (File)
Sep 1 2026, 7:35 PM
Unknown Object (File)
Aug 28 2026, 7:18 PM
View All Files
Subscribers
None

Details

Reviewers
imp
bcr
eadler
Group Reviewers
manpages
Commits
rS358920: MFC 339729:
rS339729: efivar(3): Fix some typos and improve style
Summary
  • Fix some typos.
  • Remove reudndant semicoloons from the synopsis section.
  • Stylize variable names and types with Vt and Va respectively.
  • Use a list to present non-implemented functions.
  • Sort the order of the sections.
  • Add a history section.
  • Use Nm when "libefivar" is mentioned.

Bugzilla: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=232626
Reported by: Tiwei Bie <btw@mail.ustc.edu.cn>

Test Plan
  • igor
  • mandoc -Tlint

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20389
Build 19829: arc lint + arc unit

Event Timeline

0mp created this revision.Oct 24 2018, 3:47 PM
Herald added a reviewer: manpages. · View Herald TranscriptOct 24 2018, 3:47 PM
Harbormaster completed remote builds in B20389: Diff 49556.Oct 24 2018, 3:47 PM
bcr accepted this revision.Oct 24 2018, 4:34 PM

Nice, thanks for working on this. Approved!

This revision is now accepted and ready to land.Oct 24 2018, 4:34 PM
imp accepted this revision.Oct 24 2018, 8:24 PM

lgtm

0mp added a comment.Oct 25 2018, 8:31 AM

Thanks for your reviews!

BTW, @imp & @bcr, should I MFC this one?

imp added a comment.Oct 25 2018, 3:32 PM
In D17686#378101, @0mp wrote:

Thanks for your reviews!

BTW, @imp & @bcr, should I MFC this one?

Yes

Closed by commit rS339729: efivar(3): Fix some typos and improve style (authored by 0mp). · Explain WhyOct 25 2018, 3:41 PM
This revision was automatically updated to reflect the committed changes.
0mp added a comment.Oct 25 2018, 3:41 PM

Alright, I'll try to MFC then. Thanks!

0mp added a commit: rS358920: MFC 339729:.Mar 12 2020, 8:51 PM

Revision Contents
Changeset List

PathSize
lib/
libefivar/
58 lines

Diff 49556

View Options

lib/libefivar/efivar.3

Loading...