Page MenuHomeFreeBSD

efivar(3): Fix some typos and improve style
ClosedPublic

Authored by 0mp on Oct 24 2018, 3:47 PM.
Tags
None
Referenced Files
F108178124: D17686.diff
Wed, Jan 22, 7:00 AM
Unknown Object (File)
Dec 20 2024, 1:34 AM
Unknown Object (File)
Dec 17 2024, 11:01 PM
Unknown Object (File)
Dec 15 2024, 8:52 AM
Unknown Object (File)
Oct 3 2024, 9:28 PM
Unknown Object (File)
Oct 3 2024, 3:13 PM
Unknown Object (File)
Oct 3 2024, 10:54 AM
Unknown Object (File)
Oct 3 2024, 9:46 AM
Subscribers
None

Details

Summary
  • Fix some typos.
  • Remove reudndant semicoloons from the synopsis section.
  • Stylize variable names and types with Vt and Va respectively.
  • Use a list to present non-implemented functions.
  • Sort the order of the sections.
  • Add a history section.
  • Use Nm when "libefivar" is mentioned.

Bugzilla: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=232626
Reported by: Tiwei Bie <btw@mail.ustc.edu.cn>

Test Plan
  • igor
  • mandoc -Tlint

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20389
Build 19829: arc lint + arc unit

Event Timeline

Nice, thanks for working on this. Approved!

This revision is now accepted and ready to land.Oct 24 2018, 4:34 PM

Thanks for your reviews!

BTW, @imp & @bcr, should I MFC this one?

In D17686#378101, @0mp wrote:

Thanks for your reviews!

BTW, @imp & @bcr, should I MFC this one?

Yes

This revision was automatically updated to reflect the committed changes.

Alright, I'll try to MFC then. Thanks!