Page MenuHomeFreeBSD
Differential D17686

efivar(3): Fix some typos and improve style
ClosedPublic
Actions

Authored by 0mp on Oct 24 2018, 3:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 20, 10:36 AM
Unknown Object (File)
Mon, Oct 20, 10:36 AM
Unknown Object (File)
Mon, Oct 20, 10:36 AM
Unknown Object (File)
Sun, Oct 19, 8:07 PM
Unknown Object (File)
Mon, Oct 13, 12:23 PM
Unknown Object (File)
Sep 16 2025, 6:03 AM
Unknown Object (File)
Aug 2 2025, 4:12 PM
Unknown Object (File)
Jul 28 2025, 2:22 PM
View All 91 Files
Subscribers
None

Details

Reviewers
imp
bcr
eadler
Group Reviewers
manpages
Commits
rS358920: MFC 339729:
rS339729: efivar(3): Fix some typos and improve style
Summary
  • Fix some typos.
  • Remove reudndant semicoloons from the synopsis section.
  • Stylize variable names and types with Vt and Va respectively.
  • Use a list to present non-implemented functions.
  • Sort the order of the sections.
  • Add a history section.
  • Use Nm when "libefivar" is mentioned.

Bugzilla: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=232626
Reported by: Tiwei Bie <btw@mail.ustc.edu.cn>

Test Plan
  • igor
  • mandoc -Tlint

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

0mp created this revision.Oct 24 2018, 3:47 PM
Herald added a reviewer: manpages. · View Herald TranscriptOct 24 2018, 3:47 PM
Harbormaster completed remote builds in B20389: Diff 49556.Oct 24 2018, 3:47 PM
bcr accepted this revision.Oct 24 2018, 4:34 PM

Nice, thanks for working on this. Approved!

This revision is now accepted and ready to land.Oct 24 2018, 4:34 PM
imp accepted this revision.Oct 24 2018, 8:24 PM

lgtm

0mp added a comment.Oct 25 2018, 8:31 AM

Thanks for your reviews!

BTW, @imp & @bcr, should I MFC this one?

imp added a comment.Oct 25 2018, 3:32 PM
In D17686#378101, @0mp wrote:

Thanks for your reviews!

BTW, @imp & @bcr, should I MFC this one?

Yes

Closed by commit rS339729: efivar(3): Fix some typos and improve style (authored by 0mp). · Explain WhyOct 25 2018, 3:41 PM
This revision was automatically updated to reflect the committed changes.
0mp added a comment.Oct 25 2018, 3:41 PM

Alright, I'll try to MFC then. Thanks!

0mp added a commit: rS358920: MFC 339729:.Mar 12 2020, 8:51 PM

Revision Contents
Changeset List

PathSize
head/
lib/
libefivar/
58 lines

Diff 49613

View Options

head/lib/libefivar/efivar.3

Loading...