Page MenuHomeFreeBSD

ps(1): Add a standard exit status section.
ClosedPublic

Authored by 0mp on Sep 13 2018, 7:41 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, May 4, 11:49 PM
Unknown Object (File)
Thu, Apr 24, 5:56 AM
Unknown Object (File)
Thu, Apr 17, 11:44 PM
Unknown Object (File)
Wed, Apr 16, 5:29 AM
Unknown Object (File)
Mon, Apr 14, 11:04 AM
Unknown Object (File)
Mon, Apr 14, 6:40 AM
Unknown Object (File)
Mon, Apr 14, 4:10 AM
Unknown Object (File)
Sun, Apr 13, 11:49 PM

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19559
Build 19144: arc lint + arc unit

Event Timeline

Approved, thanks for working on it.

This revision is now accepted and ready to land.Sep 13 2018, 9:30 AM
0mp added subscribers: krion, mat.

@mat, @krion, may I have your approval?

This is not wrong, but perhaps some details about different types of errors may be helpful, such as that nonexistent usernames in -U are immediately fatal while an empty result (such as from only nonexistent process IDs in -p or only existing users that do not currently run any process in -U) still writes the header line (if not disabled) and also returns a non-zero exit status.

This revision was automatically updated to reflect the committed changes.

@jilles do you think we could open another PR for your suggestions?

This is not wrong, but perhaps some details about different types of errors may be helpful, such as that nonexistent usernames in -U are immediately fatal while an empty result (such as from only nonexistent process IDs in -p or only existing users that do not currently run any process in -U) still writes the header line (if not disabled) and also returns a non-zero exit status.

I've created a PR for this: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=232852