Page MenuHomeFreeBSD
Differential D17132

PR228448: `unlink -foo` , the original use of `unlink`, no longer works.
ClosedPublic
Actions

Authored by yuripv on Sep 12 2018, 12:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 13, 1:00 AM
Unknown Object (File)
Sun, May 12, 7:42 AM
Unknown Object (File)
Sat, May 11, 2:49 PM
Unknown Object (File)
Apr 28 2024, 6:21 AM
Unknown Object (File)
Mar 11 2024, 4:16 PM
Unknown Object (File)
Mar 11 2024, 4:15 PM
Unknown Object (File)
Mar 11 2024, 4:15 PM
Unknown Object (File)
Mar 8 2024, 2:15 AM
View All 33 Files
Subscribers
0mp
imp

Details

Reviewers
emaste
kevans
vangyzen
0mp
Group Reviewers
manpages
Commits
rS338620: Fix unlink(1) for files starting with -
Summary

Restore the original behavior of unlink(1), passing the provided filename
directly to unlink(2), handling the first argument being "--" correctly.

This fixes the unlink -foo, broken in r97533.

Reported by: Brennan Vincent <brennan@umanwizard.com>
Submitted by: Brennan Vincent <brennan@umanwizard.com>
PR: 228448

Test Plan

$ kyua test -k /usr/tests/Kyuafile bin/rm
bin/rm/rm_test:unlink_dash_filename -> passed [0.088s]

Results file id is usr_tests.20180912-125312-617400
Results saved to /home/yuri/.kyua/store/results.usr_tests.20180912-125312-617400.db

1/1 passed (0 failed)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

yuripv created this revision.Sep 12 2018, 12:58 PM
Herald added a reviewer: manpages. · View Herald TranscriptSep 12 2018, 12:58 PM
Herald added a subscriber: imp. · View Herald Transcript
emaste accepted this revision.Sep 12 2018, 1:19 PM
This revision is now accepted and ready to land.Sep 12 2018, 1:19 PM
kevans accepted this revision.Sep 12 2018, 1:33 PM
vangyzen accepted this revision.Sep 12 2018, 1:56 PM
emaste added a comment.Sep 12 2018, 2:26 PM

I'll send the request to re@

0mp accepted this revision.Sep 12 2018, 5:53 PM
0mp added a subscriber: 0mp.

The manpage update looks fine.

Closed by commit rS338620: Fix unlink(1) for files starting with - (authored by emaste). · Explain WhySep 12 2018, 7:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
bin/
rm/
5 lines
9 lines
13 lines
tests/
5 lines
11 lines
45 lines
etc/
mtree/
2 lines

Diff 47964

View Options

head/bin/rm/Makefile

Loading...
View Options

head/bin/rm/rm.1

Loading...
View Options

head/bin/rm/rm.c

Loading...
View Options

head/bin/rm/tests/Makefile

Loading...
View Options

head/bin/rm/tests/Makefile.depend

Loading...
View Options

head/bin/rm/tests/rm_test.sh

Loading...
View Options

head/etc/mtree/BSD.tests.dist

Loading...