Add new option to geom(8) utility, "-p". It makes it easy to look up GEOM class instance from the provider name.
Details
Details
- Reviewers
oshogbo 0mp - Group Reviewers
manpages - Commits
- rS338640: Add new option to the geom(8) utility, "-p". It makes it easy to look up
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 19518 Build 19110: arc lint + arc unit
Event Timeline
Comment Actions
I proposed some minor changes.
| sbin/geom/core/geom.8 | ||
|---|---|---|
| 27 | Don't forgot about it :) | |
| sbin/geom/core/geom.c | ||
| 665 | Should be return (gp); | |
| 677 | Incorrect according to the style(9). | |
| 682 | Do we want to handle negative numbers explicit here? | |
| 683 | Do we need to strdup it? | |
| 692 | Over 80. | |
| 694 | Over 80, should be: show_tree_geom(mesh, gp2,
indent + 2); | |
| 702 | Missing dot at the end of the sentence. | |
| 712 | This whole part is only when gerprogname is equals to 'geom' maybe is worth doing something like geom_main? | |
| 713 | Over 80. | |
| 829 | Missing dot at the end of the sentence. | |
Comment Actions
Also, are those standard options for valid for any *standard command*? If so then the synopsis section should look a little bit different since at the moment it suggests that the only valid uses of -p and -t are geom -t and geom -p provider-name.
| sbin/geom/core/geom.8 | ||
|---|---|---|
| 110 | Is there a reason why it's -width ".Cm status" instead of -width "-p"? | |
| 111 | Did you mean .It Fl p Ar provider-name? The -p option expects an argument, right? | |
| sbin/geom/core/geom.8 | ||
|---|---|---|
| 110 | It's to keep it aligned with the .Bl above. | |
| sbin/geom/core/geom.c | ||
| 682 | Let's leave the "tree" part for another review, it needs more work. | |
| 683 | I never remember. It seems to be a pretty common pattern. | |
| 712 | Nah, it's just a few lines of code. Besides it would result in a rather weird flow, since we would call geom_main() and in some cases it would return, and in others it wouldn't. | |
Comment Actions
Those options are only to be used with geom(8), not gwhatever(8) commands nor the "standard commands" like the "list" or "load".