Add "geom -p".

[trasz]

Summary

Add new option to geom(8) utility, "-p". It makes it easy to look up GEOM class instance from the provider name.

[trasz]

Add -t.

[oshogbo]

I proposed some minor changes.

sbin/geom/core/geom.8

27

Don't forgot about it :)

sbin/geom/core/geom.c

667

Should be return (gp);

679

Incorrect according to the style(9).

684

Do we want to handle negative numbers explicit here?

685

Do we need to strdup it?

694

Over 80.

696

Over 80, should be:

show_tree_geom(mesh, gp2,
     indent + 2);

704

Missing dot at the end of the sentence.
In other cases when errx is used the dot is present.

714

This whole part is only when gerprogname is equals to 'geom' maybe is worth doing something like geom_main?

715

Over 80.

831

Missing dot at the end of the sentence.
In other cases when errx is used the dot is present.

[0mp]

Also, are those standard options for valid for any *standard command*? If so then the synopsis section should look a little bit different since at the moment it suggests that the only valid uses of -p and -t are geom -t and geom -p provider-name.

sbin/geom/core/geom.8

110

Is there a reason why it's -width ".Cm status" instead of -width "-p"?

111

Did you mean .It Fl p Ar provider-name? The -p option expects an argument, right?

[trasz]

Fix issues and drop -t for the moment.

[trasz]

sbin/geom/core/geom.8

110

It's to keep it aligned with the .Bl above.

sbin/geom/core/geom.c

684

Let's leave the "tree" part for another review, it needs more work.

685

I never remember. It seems to be a pretty common pattern.

714

Nah, it's just a few lines of code. Besides it would result in a rather weird flow, since we would call geom_main() and in some cases it would return, and in others it wouldn't.

[trasz]

Style.

[trasz]

Fix .Dd.

[trasz]

In D17116#365084, @0mp wrote:

Also, are those standard options for valid for any *standard command*? If so then the synopsis section should look a little bit different since at the moment it suggests that the only valid uses of -p and -t are geom -t and geom -p provider-name.

Those options are only to be used with geom(8), not gwhatever(8) commands nor the "standard commands" like the "list" or "load".

[0mp]

The manpage update looks fine.

sbin/geom/core/geom.8

110

+1

[bcr]

Yes, manpage update approved by mentor, although this is not needed with a src bit. ;-)

sbin/geom/core/geom.8

27

You are the wind beneath my wings, @oshogbo. ;-)

[oshogbo]

One minor change. Besides that LGTM.

sbin/geom/core/geom.8

27

xD

sbin/geom/core/geom.c

702

According to style(9) only boolean can be used like that.
Should be:
if (provider_name != NULL)