Page MenuHomeFreeBSD

Only set PORTDOCS/PORTEXAMPLES if their respective options are in OPTIONS_DEFINE.
ClosedPublic

Authored by mat on Dec 27 2017, 1:55 PM.
Tags
None
Referenced Files
F105572533: D13651.id47438.largetrue.diff
Tue, Dec 17, 7:48 PM
F105569910: D13651.id47616.largetrue.diff
Tue, Dec 17, 6:58 PM
F105569828: D13651.id47342.largetrue.diff
Tue, Dec 17, 6:57 PM
F105569014: D13651.id47240.largetrue.diff
Tue, Dec 17, 6:43 PM
F105562520: D13651.id47240.diff
Tue, Dec 17, 4:56 PM
F105562487: D13651.id46131.diff
Tue, Dec 17, 4:56 PM
F105562328: D13651.id47616.diff
Tue, Dec 17, 4:53 PM
F105561107: D13651.id37093.diff
Tue, Dec 17, 4:37 PM

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 19259
Build 18872: arc lint + arc unit

Event Timeline

  • Fix message.
  • Refactor.

This is an insanely good idea.

Mk/bsd.sanity.mk
161

The language here is a little confusing. Try one of:

PORT{_type} does not do anything unless the ${_type} option is present

PORT{_type} does not do anything without OPTIONS_DEFINE=${_type}

Personally I like the second one.

  • Make the error less unreadable.
jbeich added inline comments.
games/openbor/Makefile
66

Please, sort the values alphabetically.

mat marked 2 inline comments as done.Aug 24 2018, 3:19 PM
  • fixup! Add DOCS and EXAMPLES options where applicable
  • fixup! Add DOCS and EXAMPLES options where applicable
  • fixup! Only set PORTDOCS/PORTEXAMPLES if their respective options are in OPTIONS_DEFINE.
  • Make sure DOCS and EXAMPLES are there to be tested, even if excluded.
mat added a subscriber: antoine.

Rebase & fix feedback from @antoine.

  • fixup! Add DOCS and EXAMPLES options where applicable

Reorder changes:

  • After an include, PLIST_SUB must be appended to, not overwritten.
  • Add DOCS options to ports that should have one.
  • Add EXAMPLES options to ports that should have one.
  • Various cleanup & fixes post-DOCS/EXAMPLES cleanup.
  • Add a DEV_ERROR if PORTDOCS/PORTEXAMPLES are set and DOCS/EXAMPLES
  • Only set %%PORTDOCS%%/%%PORTEXAMPLES%% if a DOCS/EXAMPLES option is defined.

fixups post exp-run:

  • fixup! Add DOCS options to ports that should have one.
  • fixup! Add DOCS options to ports that should have one.
  • fixup! Add DOCS options to ports that should have one.
  • fixup! Add DOCS options to ports that should have one.
  • fixup! Add EXAMPLES options to ports that should have one.

Add a forgotten patch limiting PORTDOCS/EXAMPLES to only be useful if their options are there.

Rebase and one more fixup.

  • fixup! Add DOCS options to ports that should have one.
  • fixup! Add DOCS options to ports that should have one.
  • fixup! Add DOCS options to ports that should have one.

Rebase and fix www/nginx.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 10 2018, 1:16 PM
This revision was automatically updated to reflect the committed changes.