Details
Details
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
This is an insanely good idea.
Mk/bsd.sanity.mk | ||
---|---|---|
161 ↗ | (On Diff #46130) | The language here is a little confusing. Try one of: PORT{_type} does not do anything unless the ${_type} option is present PORT{_type} does not do anything without OPTIONS_DEFINE=${_type} Personally I like the second one. |
games/openbor/Makefile | ||
---|---|---|
66 ↗ | (On Diff #46131) | Please, sort the values alphabetically. |
Comment Actions
- fixup! Add DOCS and EXAMPLES options where applicable
- fixup! Add DOCS and EXAMPLES options where applicable
Comment Actions
- fixup! Only set PORTDOCS/PORTEXAMPLES if their respective options are in OPTIONS_DEFINE.
Comment Actions
Reorder changes:
- After an include, PLIST_SUB must be appended to, not overwritten.
- Add DOCS options to ports that should have one.
- Add EXAMPLES options to ports that should have one.
- Various cleanup & fixes post-DOCS/EXAMPLES cleanup.
- Add a DEV_ERROR if PORTDOCS/PORTEXAMPLES are set and DOCS/EXAMPLES
- Only set %%PORTDOCS%%/%%PORTEXAMPLES%% if a DOCS/EXAMPLES option is defined.
fixups post exp-run:
- fixup! Add DOCS options to ports that should have one.
- fixup! Add DOCS options to ports that should have one.
- fixup! Add DOCS options to ports that should have one.
- fixup! Add DOCS options to ports that should have one.
- fixup! Add EXAMPLES options to ports that should have one.
Comment Actions
Add a forgotten patch limiting PORTDOCS/EXAMPLES to only be useful if their options are there.
Comment Actions
- fixup! Add DOCS options to ports that should have one.
- fixup! Add DOCS options to ports that should have one.
- fixup! Add DOCS options to ports that should have one.