Fix excessive reseed rate in random(4).
ClosedPublic
Actions

Authored by markm on Aug 23 2018, 4:46 PM.

Details

Reviewers

cem
jmg
delphij

Group Reviewers

secteam
O3: Kernel Random Numbers Generator

Commits

rS338292: Fix braino of mine where the reseeds would happen far too often,

Summary

Fix braino of mine where the reseeds would happen far too often, making the kernel process way too busy.
PR: 230808
Submitted by: Conrad Meyer <cem@FreeBSD.org>
Reported by: Danilo Egea Gondolfo <danilo@FreeBSD.org>

Test Plan

Make the PRNG work hard while doing something intensive like "make
world". To make the PRNG work hard, do e.g.
$ dd if=/dev/random of=/dev/null bs=$((1024*1024))

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markm created this revision.Aug 23 2018, 4:46 PM

Harbormaster completed remote builds in B19105: Diff 47181.Aug 23 2018, 4:46 PM

Apologies to delphij for abandoning the previous identical-looking commit. I was making a pig's ear of the archanist work.

LGTM from an earlier review.

This revision is now accepted and ready to land.Aug 23 2018, 5:08 PM

Copied from earlier review D16866:

This one looks obviously correct to me. Go ahead and commit it. It fixes a security weakness in our implementation relative to spec Fortuna, so I'd be sure to tag the commit with "Security: yes."

Thanks folks! Tinderbox build going, then I'll commit.

Closed by commit rS338292: Fix braino of mine where the reseeds would happen far too often, (authored by markm). · Explain WhyAug 24 2018, 2:54 PM

This revision was automatically updated to reflect the committed changes.

Owners added a reviewer: O3: Kernel Random Numbers Generator.Aug 24 2018, 2:54 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 24 2018, 2:54 PM