Fix generation of krb5-config with LC_CTYPE=*.UTF-8
ClosedPublic
Actions

Authored by arichardson on Aug 22 2018, 5:01 PM.

Tags

None

Referenced Files

	F167050896: D16849.id47111.diff
	Tue, Aug 18, 8:00 PM

	F167038316: D16849.diff
	Tue, Aug 18, 5:07 PM

	Unknown Object (File)
	Mon, Aug 17, 6:12 PM

	Unknown Object (File)
	Sun, Aug 16, 9:57 PM

	Unknown Object (File)
	Mon, Aug 10, 8:39 PM

	Unknown Object (File)
	Mon, Aug 10, 8:37 PM

	Unknown Object (File)
	Sat, Jul 25, 4:27 PM

	Unknown Object (File)
	Tue, Jul 21, 7:55 AM

View All Files

Subscribers

None

Details

Reviewers

jhb
emaste
brooks
imp
cy

Commits

rS349576: Fix generation of krb5-config with LC_CTYPE=*.UTF-8

Summary

When building on MacOS with a UTF-8 locale sed will fail when reading
krb-config.in due to invalid characters. Forcing the "C" locale fixes this.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19054
Build 18685: arc lint + arc unit

Event Timeline

arichardson created this revision.Aug 22 2018, 5:01 PM

Harbormaster completed remote builds in B19054: Diff 47111.Aug 22 2018, 5:02 PM

ping?

OK.

(Really, upstream should migrate the file to UTF-8 though.)

This revision is now accepted and ready to land.Feb 27 2019, 2:38 AM

lgtm

Closed by commit rS349576: Fix generation of krb5-config with LC_CTYPE=*.UTF-8 (authored by arichardson). · Explain WhyJul 1 2019, 11:48 AM

This revision was automatically updated to reflect the committed changes.

arichardson added a commit: rS349576: Fix generation of krb5-config with LC_CTYPE=*.UTF-8.

Revision Contents
Changeset List

Path

Size

kerberos5/

usr.bin/

krb5-config/

Makefile

6 lines

Diff 47111

View Options

kerberos5/usr.bin/krb5-config/Makefile

Fix generation of krb5-config with LC_CTYPE=*.UTF-8ClosedPublicActions