Details

etc/Makefile
179	this whole thing is unrelated.
sbin/devd/Makefile
11	this is wrong. Extra .if. However, it's also bogus for devmatch.conf: that should be installed everywhere.

will requested changes to this revision.Aug 18 2018, 9:23 PM

will added inline comments.

etc/Makefile
179	I agree, this section removal belongs to another commit.
sbin/devd/Makefile
11	Agree. I'm not seeing the corresponding deletes, so I'm guessing the commit was meant to include a different `etc/Makefile`.

This revision now requires changes to proceed.Aug 18 2018, 9:23 PM

brd added inline comments.Aug 18 2018, 11:05 PM

etc/Makefile
179	Opps, yeah, I thought my tree was clean, obviously not. Will update.

Update with right etc/Makefile changes

Harbormaster completed remote builds in B18943: Diff 46912.Aug 18 2018, 11:15 PM

brd marked 3 inline comments as done.Aug 18 2018, 11:15 PM

Address @imp feedback

Harbormaster completed remote builds in B18944: Diff 46913.Aug 18 2018, 11:20 PM

will added inline comments.Aug 19 2018, 8:44 AM

sbin/devd/Makefile
10	I think you mean `/etc/devd`? You've tested this?

Fix a few typos after real testing

Harbormaster completed remote builds in B18961: Diff 46953.Aug 20 2018, 1:56 AM

brd marked an inline comment as done.Aug 20 2018, 1:58 AM

brd added inline comments.

sbin/devd/Makefile
10	I have now that I am back and fixed my build box.

brd marked 4 inline comments as done.Aug 20 2018, 3:08 AM

brd added a reviewer: imp.Aug 20 2018, 3:28 AM

will accepted this revision.Aug 21 2018, 2:06 AM

This revision is now accepted and ready to land.Aug 21 2018, 2:06 AM

imp added inline comments.Aug 21 2018, 3:27 AM

sbin/devd/Makefile
11	Do we really need this? HYPERV is only true here. And ACPI is also true on arm64. the asus.conf is valid there IMHO.
24	It would be better to use MACHINE_CPUARCH here... This is userland, so keying off the kernel arch ($MACHINE) is not right.

Address @imp feedback

This revision now requires review to proceed.Aug 21 2018, 4:07 PM

Harbormaster completed remote builds in B19013: Diff 47044.Aug 21 2018, 4:07 PM

brd marked 2 inline comments as done.Aug 21 2018, 4:08 PM

imp accepted this revision.Aug 21 2018, 4:19 PM

This revision is now accepted and ready to land.Aug 21 2018, 4:19 PM

Closed by commit rS338144: Move all devd related configs to sbin/devd/ (authored by brd). · Explain WhyAug 21 2018, 4:52 PM

This revision was automatically updated to reflect the committed changes.

Move all devd related configs to sbin/devd/
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 46953

etc/Makefile

etc/devd/

etc/devd.conf

etc/devd/Makefile

etc/devd/apple.conf

etc/devd/asus.conf

etc/devd/devmatch.conf

etc/devd/hyperv.conf

etc/devd/uath.conf

etc/devd/ulpt.conf

etc/devd/zfs.conf

sbin/devd/Makefile

sbin/devd/apple.conf

sbin/devd/asus.conf

sbin/devd/devd.conf

sbin/devd/devmatch.conf

sbin/devd/hyperv.conf

sbin/devd/uath.conf

sbin/devd/ulpt.conf

sbin/devd/zfs.conf

Move all devd related configs to sbin/devd/ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 46953

etc/Makefile

etc/devd/

etc/devd.conf

etc/devd/Makefile

etc/devd/apple.conf

etc/devd/asus.conf

etc/devd/devmatch.conf

etc/devd/hyperv.conf

etc/devd/uath.conf

etc/devd/ulpt.conf

etc/devd/zfs.conf

sbin/devd/Makefile

sbin/devd/apple.conf

sbin/devd/asus.conf

sbin/devd/devd.conf

sbin/devd/devmatch.conf

sbin/devd/hyperv.conf

sbin/devd/uath.conf

sbin/devd/ulpt.conf

sbin/devd/zfs.conf

Move all devd related configs to sbin/devd/
ClosedPublic
Actions

Revision Contents
Changeset List