libfdt: Update to 1.5.0
Needs ReviewPublic
Actions

Authored by kevans on Aug 9 2018, 9:24 PM.

Details

Reviewers

None

Group Reviewers

ARM
arm64
PowerPC

Summary

Highlights of 1.4.7:

Compat fixes by @nwhitehorn (previously cherry-picked already)
Improved memory/sanity checks

Highlight of 1.5.0:

Faster unaligned access (6x faster being observed on some ARM platforms [from dtc commit])

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 18685

Event Timeline

kevans created this revision.Aug 9 2018, 9:24 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 9 2018, 9:24 PM

Harbormaster completed remote builds in B18685: Diff 46486.Aug 9 2018, 9:24 PM

Was the larger size an issue for us?

Looks OK to me. One question: Do we want the various instances of fdt_check_header() in our code to be spelled FDT_RO_PROBE() now?

Ping?

In D16653#353877, @imp wrote:

Was the larger size an issue for us?

Not that I'm aware of.

In D16653#354587, @nwhitehorn wrote:

Looks OK to me. One question: Do we want the various instances of fdt_check_header() in our code to be spelled FDT_RO_PROBE() now?

Yeah, neither loader nor the kernel need care for the extra bits done by fdt_check_header. I'll spin up a patch to do this conversion separately, to be committed after the 1.5.0 update since it's not critical.

In D16653#434852, @emaste wrote:

Ping?

I'm going to import libfdt 1.5.0 and update this.

kevans updated this revision to Diff 57822.May 24 2019, 2:18 AM

kevans retitled this revision from libfdt: Update to the full release of 1.4.7 to libfdt: Update to 1.5.0.

kevans edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B24461: Diff 57822.May 24 2019, 2:18 AM

In D16653#439951, @kevans wrote:

In D16653#354587, @nwhitehorn wrote:

Looks OK to me. One question: Do we want the various instances of fdt_check_header() in our code to be spelled FDT_RO_PROBE() now?

Yeah, neither loader nor the kernel need care for the extra bits done by fdt_check_header. I'll spin up a patch to do this conversion separately, to be committed after the 1.5.0 update since it's not critical.