Why not make an extra flavor too?

It seems you forgot to add revert the pkg-plist deletion.

In D16387#348109, @lbdm_privacychain.ch wrote:

Done.

Converting libfm-extra to FLAVOR (libfm@extra) resulted on:

Warning: (x11/libfm@gtk3): Error: x11/libfm incorrectly depends on itself.

Thanks! ^^

This does not look like a ports framework message, but a poudriere one. Poke @bdrewery.

I was wondering about the two plists. the only difference is libfm-gtk3.so* and the libfm-gtk3.pc, it would probably be better to add this:

.if ${FLAVOR} = gtk2
PLIST_SUB= GTK3=
.else
PLIST_SUB= GTK3=3
.endif

and write libfm-gtk%%GTK3%%.* in the pkg-plist file, it would save on maintenance.

In D16387#348376, @lbdm_privacychain.ch wrote:

Strictly following the example would break the gtk2 version, and so I changed it a bit.

Not sure what it would break, but ok.

There are other ports depending on the now flavored x11/libfm -- maybe they should be flavored too? -- like x11/lxpanel.

Is the flavoring really needed?
The number of packages is exploding

IIRC LXDE can be completely FLAVORed however I guess just a handful of people should be using it on FreeBSD, and that is one of the reasons I didn't FLAVORed evertyhing since the beginning ( I think it does not worth the work ).

The second reason is pcmanfm/libfm are not part of LXDE development group anymore. They are now developed in separated since there are tons of people using them outside LXDE ( I guess there are more people using only pcmanfm/libfm in total than using LXDE in general, since pcmanfm is present in most of the WMs installations ).

Also, IIRC the next LXDE and pcmanfm/libfm version will be gtk3 only, I just don't have idea when they will come out.

Thanks!

Could you remove all the whitespace changes? They makes it hard to see what you are actually changing.

Hi @mat,

Do you mean the tab space I've added in some ports? There were some without space after =.

I will revert them, the actual important change is the addition of @gtk2 on the libfm dependency:

libfm-gtk.so:x11/libfm@gtk2

Why do you remove all the Created by lines, were those removal requested?

In D16387#398067, @mat wrote:

Why do you remove all the Created by lines, were those removal requested?

Given the previous direction when reviewing x11/i3blocks, to remove that line without asking, I took that as a default behavior. ^^

"Created by" lines should never be removed without the express consent of the person named in there. Please, put them all back.

In D16387#398099, @rigoletto wrote:

In D16387#398067, @mat wrote:

Why do you remove all the Created by lines, were those removal requested?

Given the previous direction when reviewing x11/i3blocks, to remove that line without asking, I took that as a default behavior. ^^

Just to explain the history here, there used to be a "# Created by line" long ago, it has been decided, that this wasn't necessary anymore, so we do recommend on new things not to add that line anymore, but it should be left on historical makefiles except if the initial creator accept removing it explicitly

In D16387#400407, @tcberner wrote:

Looks good to me. Do you have the maintainers approval?

I think the @jsm reply on bugs was a yes. Same for Chris (@portmaster_BSDforge.com). ^^