Differential D16175

Use appropriate MSS when populating the TCP fast open client cookie cache
ClosedPublic
Actions

Authored by tuexen on Jul 8 2018, 9:48 AM.

Tags

None

Referenced Files

	F168681219: D16175.diff
	Sat, Aug 29, 2:39 PM

	F168681218: D16175.diff
	Sat, Aug 29, 2:39 PM

	F168498275: D16175.id45106.diff
	Fri, Aug 28, 5:03 PM

	F168492777: D16175.diff
	Fri, Aug 28, 4:22 PM

	F168490222: D16175.id45008.diff
	Fri, Aug 28, 4:04 PM

	Unknown Object (File)
	Thu, Aug 27, 9:07 AM

	Unknown Object (File)
	Wed, Aug 26, 4:04 PM

	Unknown Object (File)
	Tue, Aug 25, 7:52 AM

Subscribers

Details

Reviewers

pkelsey
jason_eggnet.com
rrs
kbowling
jtl

Group Reviewers

Commits

rS336167: Use appropriate MSS value when populating the TCP FO client cookie cache

Summary

When a client receives a SYN-ACK segment with a TFP fast open cookie, but without an MSS option, an MSS value from uninitialised stack memory is used. This patch ensures that in case no MSS option is included in the SYN-ACK, the appropriate value as given in the TCP fast open RFC is used.

Test Plan

Use a packetdrill script to trigger the condition and use D14554 to verify the correct MSS is used.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 17903

Event Timeline

tuexen created this revision.Jul 8 2018, 9:48 AM

Herald added 1 blocking reviewer(s): transport. · View Herald TranscriptJul 8 2018, 9:48 AM

Herald added a subscriber: imp. · View Herald Transcript

Harbormaster completed remote builds in B17903: Diff 45008.Jul 8 2018, 9:48 AM

kbowling accepted this revision.Jul 9 2018, 9:23 AM

This revision is now accepted and ready to land.Jul 9 2018, 9:23 AM

Closed by commit rS336167: Use appropriate MSS value when populating the TCP FO client cookie cache (authored by tuexen). · Explain WhyJul 10 2018, 10:42 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

15 lines

tcp_stacks/

30 lines

15 lines

Diff 45008

sys/netinet/tcp_input.c

Loading...

sys/netinet/tcp_stacks/fastpath.c

Loading...

sys/netinet/tcp_stacks/rack.c

Loading...