Retain offset compatibility with pre-12.0 dumps
ClosedPublic
Actions

Authored by cem on Jun 15 2018, 6:45 PM.

Details

Reviewers

markj
def
asomers
jhb

Commits

rS335227: Retain offset compatibility with pre-12.0 dumps

Summary

As a follow-up to r324965, which adds support for compressed kernel dumps,
readjust dump header members slightly to mostly preserve ABI (somewhat) with
earlier (11.x and older) dumps.

Test Plan

This change does burn 4 bytes of panicstr, but I think that is a worthwhile
tradeoff. An alternative approach that doesn't burn 4 bytes of panicstr would
be to misalign the 8-byte dumpextent field, which would also be fine with me.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17310
Build 17145: arc lint + arc unit

Event Timeline

cem created this revision.Jun 15 2018, 6:45 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 15 2018, 6:45 PM

Harbormaster completed remote builds in B17310: Diff 43838.Jun 15 2018, 6:45 PM

cem added a parent revision: D11723: Add support for compressed kernel dumps..Jun 15 2018, 6:45 PM

I think this is fine. The panic string buffer is bigger than it needs to be.

We already have the compile-time assert in all the MD dump files.

This revision is now accepted and ready to land.Jun 15 2018, 6:51 PM

In D15829#334743, @markj wrote:

I think this is fine. The panic string buffer is bigger than it needs to be.

We already have the compile-time assert in all the MD dump files.

Thanks! I'll remove the assert before commit.

Closed by commit rS335227: Retain offset compatibility with pre-12.0 dumps (authored by cem). · Explain WhyJun 15 2018, 7:03 PM

This revision was automatically updated to reflect the committed changes.