Page MenuHomeFreeBSD

Retain offset compatibility with pre-12.0 dumps
ClosedPublic

Authored by cem on Jun 15 2018, 6:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 24, 11:06 AM
Unknown Object (File)
Fri, Nov 22, 8:08 AM
Unknown Object (File)
Wed, Nov 13, 2:27 PM
Unknown Object (File)
Fri, Nov 1, 2:48 AM
Unknown Object (File)
Oct 5 2024, 4:11 AM
Unknown Object (File)
Sep 30 2024, 3:14 AM
Unknown Object (File)
Sep 18 2024, 2:30 AM
Unknown Object (File)
Sep 4 2024, 8:46 PM
Subscribers

Details

Summary

As a follow-up to r324965, which adds support for compressed kernel dumps,
readjust dump header members slightly to mostly preserve ABI (somewhat) with
earlier (11.x and older) dumps.

Test Plan

This change does burn 4 bytes of panicstr, but I think that is a worthwhile
tradeoff. An alternative approach that doesn't burn 4 bytes of panicstr would
be to misalign the 8-byte dumpextent field, which would also be fine with me.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I think this is fine. The panic string buffer is bigger than it needs to be.

We already have the compile-time assert in all the MD dump files.

This revision is now accepted and ready to land.Jun 15 2018, 6:51 PM

I think this is fine. The panic string buffer is bigger than it needs to be.

We already have the compile-time assert in all the MD dump files.

Thanks! I'll remove the assert before commit.

This revision was automatically updated to reflect the committed changes.