Page MenuHomeFreeBSD

Retain offset compatibility with pre-12.0 dumps
ClosedPublic

Authored by cem on Jun 15 2018, 6:45 PM.
Tags
None
Referenced Files
F167848891: D15829.id43838.diff
Mon, Aug 24, 11:55 PM
F167755534: D15829.diff
Mon, Aug 24, 7:51 AM
F167746246: D15829.id43838.diff
Mon, Aug 24, 5:55 AM
Unknown Object (File)
Sat, Aug 22, 11:21 AM
Unknown Object (File)
Wed, Aug 12, 12:55 PM
Unknown Object (File)
Wed, Aug 12, 12:36 PM
Unknown Object (File)
Fri, Aug 7, 3:52 AM
Unknown Object (File)
Tue, Aug 4, 9:39 AM
Subscribers

Details

Summary

As a follow-up to r324965, which adds support for compressed kernel dumps,
readjust dump header members slightly to mostly preserve ABI (somewhat) with
earlier (11.x and older) dumps.

Test Plan

This change does burn 4 bytes of panicstr, but I think that is a worthwhile
tradeoff. An alternative approach that doesn't burn 4 bytes of panicstr would
be to misalign the 8-byte dumpextent field, which would also be fine with me.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I think this is fine. The panic string buffer is bigger than it needs to be.

We already have the compile-time assert in all the MD dump files.

This revision is now accepted and ready to land.Jun 15 2018, 6:51 PM

I think this is fine. The panic string buffer is bigger than it needs to be.

We already have the compile-time assert in all the MD dump files.

Thanks! I'll remove the assert before commit.

This revision was automatically updated to reflect the committed changes.