Page MenuHomeFreeBSD
Differential D15684

Add a driver for the BCM2835 Mini-UART
ClosedPublic
Actions

Authored by db on Jun 6 2018, 11:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 18 2025, 6:32 AM
Unknown Object (File)
Feb 7 2025, 5:33 AM
Unknown Object (File)
Feb 4 2025, 10:48 AM
Unknown Object (File)
Jan 19 2025, 4:54 AM
Unknown Object (File)
Jan 15 2025, 10:27 PM
Unknown Object (File)
Nov 26 2024, 7:05 PM
Unknown Object (File)
Oct 20 2024, 2:48 PM
Unknown Object (File)
Oct 20 2024, 2:48 PM
View All 67 Files
Subscribers
andrew
bobf_mrp3.com
emaste
imp

Details

Reviewers
manu
andrew
Group Reviewers
ARM
arm64
Commits
rS334997: Add a driver for the BCM2835 Mini-UART as seen on the RPi3

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 17065
Build 16926: arc lint + arc unit

Event Timeline

db created this revision.Jun 6 2018, 11:00 PM
Herald added a reviewer: manu. · View Herald TranscriptJun 6 2018, 11:00 PM
Herald added subscribers: emaste, andrew, imp. · View Herald Transcript
Harbormaster completed remote builds in B17056: Diff 43393.Jun 6 2018, 11:00 PM
manu added reviewers: ARM, arm64.Jun 6 2018, 11:03 PM
andrew added inline comments.Jun 7 2018, 12:24 AM
sys/dev/uart/uart_dev_mu.c
80–85

Is this needed?

89–95

And this?

326–336

We could probably just ignore ACPI support in a RPi only driver

db marked 3 inline comments as done.Jun 7 2018, 11:24 AM
db added inline comments.
sys/dev/uart/uart_dev_mu.c
80–85

I didn't know whether it would be needed or not. As you said, it's only on RPi with no ACPI so I have ripped it out.

89–95

Not needed without ACPI support. Tested compile.

326–336

Agreed.

db updated this revision to Diff 43405.Jun 7 2018, 11:27 AM
db marked 3 inline comments as done.

Removed ACPI

As it's only used for the RPi removed ACPI from this revision

Harbormaster completed remote builds in B17065: Diff 43405.Jun 7 2018, 11:27 AM
bobf_mrp3.com added a subscriber: bobf_mrp3.com.Jun 7 2018, 8:40 PM

may need an overlay for RPi 2

andrew added inline comments.Jun 9 2018, 8:31 PM
sys/arm64/conf/GENERIC
172

Could we call this uart_mu to be consistent with the other uart device names? It should also be sorted with the other device options.

db updated this revision to Diff 43544.Jun 10 2018, 2:02 PM
db marked an inline comment as done.

Change mu to uart_mu as requested

Harbormaster completed remote builds in B17136: Diff 43544.Jun 10 2018, 2:02 PM
andrew accepted this revision.Jun 10 2018, 3:15 PM
This revision is now accepted and ready to land.Jun 10 2018, 3:15 PM
Closed by commit rS334997: Add a driver for the BCM2835 Mini-UART as seen on the RPi3 (authored by db). · Explain WhyJun 12 2018, 1:26 PM
This revision was automatically updated to reflect the committed changes.
bobf_mrp3.com mentioned this in D15787: support for uart_dev_mu for RPI2, RPI-B.Jun 13 2018, 10:44 AM

Revision Contents
Changeset List

PathSize
sys/
arm64/
conf/
1 line
conf/
1 line
dev/
uart/
521 lines
modules/
uart/
5 lines

Diff 43405

View Options

sys/arm64/conf/GENERIC

Loading...
View Options

sys/conf/files.arm64

Loading...
View Options

sys/dev/uart/uart_dev_mu.c

Loading...
View Options

sys/modules/uart/Makefile

Loading...