Page MenuHomeFreeBSD

Add a driver for the BCM2835 Mini-UART
ClosedPublic

Authored by db on Jun 6 2018, 11:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 21, 3:57 PM
Unknown Object (File)
Thu, Mar 21, 3:57 PM
Unknown Object (File)
Feb 11 2024, 5:35 PM
Unknown Object (File)
Jan 13 2024, 7:58 PM
Unknown Object (File)
Jan 6 2024, 2:23 AM
Unknown Object (File)
Dec 28 2023, 4:34 PM
Unknown Object (File)
Dec 28 2023, 4:34 PM
Unknown Object (File)
Dec 20 2023, 3:01 AM

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sys/dev/uart/uart_dev_mu.c
79–84 ↗(On Diff #43393)

Is this needed?

88–94 ↗(On Diff #43393)

And this?

325–335 ↗(On Diff #43393)

We could probably just ignore ACPI support in a RPi only driver

db marked 3 inline comments as done.Jun 7 2018, 11:24 AM
db added inline comments.
sys/dev/uart/uart_dev_mu.c
79–84 ↗(On Diff #43393)

I didn't know whether it would be needed or not. As you said, it's only on RPi with no ACPI so I have ripped it out.

88–94 ↗(On Diff #43393)

Not needed without ACPI support. Tested compile.

325–335 ↗(On Diff #43393)

Agreed.

db marked 3 inline comments as done.

Removed ACPI

As it's only used for the RPi removed ACPI from this revision

sys/arm64/conf/GENERIC
172 ↗(On Diff #43405)

Could we call this uart_mu to be consistent with the other uart device names? It should also be sorted with the other device options.

db marked an inline comment as done.

Change mu to uart_mu as requested

This revision is now accepted and ready to land.Jun 10 2018, 3:15 PM
This revision was automatically updated to reflect the committed changes.