gcc8 has introduced the set but not used warning which is useful for identifying dead code. unfortunately a lot of temporaries used only by INVARIANTS show up as dead code as well.
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 16691
Event Timeline
sys/kern/kern_sendfile.c | ||
---|---|---|
693 | Is this a bug fix? | |
sys/kern/subr_capability.c | ||
52 | Does this turn on INVARIANTS or turn it off or undef INVARIANTS? | |
sys/kern/subr_uio.c | ||
278 | Huh ... I'm not familiar with this code, is this an actual bug fix? | |
sys/kern/uipc_sockbuf.c | ||
463 ↗ | (On Diff #42721) | This looks like a bugfix too? |
sys/kern/vfs_cache.c | ||
755 | Huh, this looks like a potential bugfix too. | |
1352 | Ugh, is this a bugfix too? | |
sys/kern/vfs_subr.c | ||
1408 | Because of the #if 0 that is being wrapped around the use of error here, should this be updated with a #if 0 and have the getnewvnode_wait() wrapped in a #if 0? |
sys/kern/subr_capability.c | ||
---|---|---|
52 | It enables all the things that are under ifdef INVARIANTS when this code is compiled for user (!_KERNEL) |