Differential D15347

Add support for cloning pseudo interfaces
ClosedPublic
Actions

Authored by mmacy on May 8 2018, 4:00 AM.

Tags

None

Referenced Files

	F108177047: D15347.diff
	Wed, Jan 22, 6:42 AM

	F108171417: D15347.diff
	Wed, Jan 22, 4:55 AM

	Unknown Object (File)
	Fri, Jan 17, 4:52 PM

	Unknown Object (File)
	Dec 8 2024, 10:48 PM

	Unknown Object (File)
	Nov 29 2024, 5:00 AM

	Unknown Object (File)
	Nov 23 2024, 1:56 AM

	Unknown Object (File)
	Nov 3 2024, 7:53 PM

	Unknown Object (File)
	Oct 20 2024, 1:19 PM

View All 68 Files

Subscribers

Details

Reviewers

shurd
tychon
sbruno

Commits

rS333502: iflib(9): Add support for cloning pseudo interfaces

Summary

Part 3 of many ...
The VPC framework relies heavily on cloning pseudo interfaces (vmnics, vpc switch, vcpswitch port, hostif, vxlan if, etc).

This pulls in that bit. Largely self explanatory. Some ancillary changes get pulled in as a side effect.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

mmacy created this revision.May 8 2018, 4:00 AM

Herald added subscribers: ae, imp. · View Herald TranscriptMay 8 2018, 4:00 AM

shurd added inline comments.May 8 2018, 4:23 PM

sys/net/iflib.c
4549	This appears to leak ctx and sc.
sys/net/iflib.h
331–360	I don't think this value should be renumbered. It's in stable/11 now as 0x100.

sbruno added inline comments.May 8 2018, 5:49 PM

sys/net/iflib.h
331–360	Maybe I'm naive, but this value seems to be only consumed by kernel space. That being said, if someone is trying to use an out of tree KMOD, then there would be a problem right?

shurd added inline comments.May 8 2018, 5:52 PM

sys/net/iflib.h
331–360	Yeah, the main concern is that if someone doesn't rebuild a module across this change, it will behave unexpectedly. Since there's no technical reason to renumber it, it may as well be retained.

Fix leak on iflib_register fail
don't renumber IFLIB_NEED_ETHER_PAD

lgtm

This revision is now accepted and ready to land.May 11 2018, 7:26 PM

mmacy added a reviewer: sbruno.May 11 2018, 7:49 PM

sbruno accepted this revision.May 11 2018, 7:55 PM

Closed by commit rS333502: iflib(9): Add support for cloning pseudo interfaces (authored by mmacy). · Explain WhyMay 11 2018, 8:08 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

conf/

1 line

net/

3 lines

5 lines

36 lines

129 lines

43 lines

384 lines

Diff 42419

sys/conf/files

Loading...

sys/net/if.h

Loading...

sys/net/if_clone.h

Loading...

sys/net/if_clone.c

Loading...

sys/net/ifdi_if.m

Loading...

sys/net/iflib.h

Loading...

sys/net/iflib.c

Loading...