Allow PCI VGA devices to be detached.
ClosedPublic
Actions

Authored by grehan on May 2 2018, 5:20 PM.

Details

Reviewers

jhb
imp
rgrimes

Group Reviewers

bhyve

Commits

rS333230: Allow PCI VGA devices to be detached.

Summary

GPUs often have VGA PCI device IDs and are probed/attached
by the VGA driver. Allow them to be detached so they can
be presented as passthru devices to VM guests.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

grehan created this revision.May 2 2018, 5:20 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 2 2018, 5:20 PM

Harbormaster completed remote builds in B16398: Diff 42069.May 2 2018, 5:20 PM

jhb accepted this revision.May 2 2018, 5:25 PM

jhb added inline comments.

sys/dev/pci/vga_pci.c
290 ↗	(On Diff #42069)	Cosmetic nits. Existing style in this file is to use 'error' instead of 'rc' and to not do assignments inside of conditionals, so: int error; error = bus_generic_detach(dev); if (error == 0) errror = device_delete_children(dev); return (error);

This revision is now accepted and ready to land.May 2 2018, 5:25 PM

How do you trigger a call to this DEVMETHOD?

In D15269#321869, @rgrimes wrote:

How do you trigger a call to this DEVMETHOD?

devctl detatch vga0

Update style as per jhb.

This revision now requires review to proceed.May 2 2018, 5:47 PM

Harbormaster completed remote builds in B16399: Diff 42072.May 2 2018, 5:47 PM

imp accepted this revision.May 2 2018, 5:51 PM

This revision is now accepted and ready to land.May 2 2018, 5:51 PM

rgrimes accepted this revision.May 2 2018, 6:15 PM

Closed by commit rS333230: Allow PCI VGA devices to be detached. (authored by grehan). · Explain WhyMay 3 2018, 10:51 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

pci/

vga_pci.c

12 lines

Diff 42114

View Options

head/sys/dev/pci/vga_pci.c

Show First 20 Lines • Show All 305 Lines • ▼ Show 20 Lines	pfprint_fp(dtrace_hdl_t dtp, FILE fp, const char *format,
switch (size) {		switch (size) {
case sizeof (float):		case sizeof (float):
return (dt_printf(dtp, fp, format,		return (dt_printf(dtp, fp, format,
(double)((float )addr) / n));		(double)((float )addr) / n));
case sizeof (double):		case sizeof (double):
return (dt_printf(dtp, fp, format,		return (dt_printf(dtp, fp, format,
((double )addr) / n));		((double )addr) / n));
#if !defined(__arm__) && !defined(__powerpc__) && \		#if !defined(__arm__) && !defined(__powerpc__) && \
!defined(__mips__) && !defined(__riscv__)		!defined(__mips__) && !defined(__riscv)
case sizeof (long double):		case sizeof (long double):
return (dt_printf(dtp, fp, format,		return (dt_printf(dtp, fp, format,
((long double )addr) / ldn));		((long double )addr) / ldn));
#endif		#endif
default:		default:
return (dt_set_errno(dtp, EDT_DMISMATCH));		return (dt_set_errno(dtp, EDT_DMISMATCH));
}		}
}		}
▲ Show 20 Lines • Show All 1,761 Lines • Show Last 20 Lines

Allow PCI VGA devices to be detached.ClosedPublicActions