Page MenuHomeFreeBSD
Differential D15269

Allow PCI VGA devices to be detached.
ClosedPublic
Actions

Authored by grehan on May 2 2018, 5:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Aug 19, 1:28 AM
Unknown Object (File)
Tue, Aug 18, 5:34 PM
Unknown Object (File)
Sun, Aug 16, 8:23 AM
Unknown Object (File)
Fri, Aug 14, 8:51 PM
Unknown Object (File)
Thu, Aug 13, 7:43 AM
Unknown Object (File)
Mon, Aug 10, 7:26 PM
Unknown Object (File)
Mon, Aug 10, 7:26 PM
Unknown Object (File)
Sat, Aug 1, 11:13 PM
View All Files
Subscribers
imp
rgrimes

Details

Reviewers
jhb
imp
rgrimes
Group Reviewers
bhyve
Commits
rS333230: Allow PCI VGA devices to be detached.
Summary

GPUs often have VGA PCI device IDs and are probed/attached
by the VGA driver. Allow them to be detached so they can
be presented as passthru devices to VM guests.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 16399
Build 16324: arc lint + arc unit

Event Timeline

grehan created this revision.May 2 2018, 5:20 PM
Herald added a subscriber: imp. · View Herald TranscriptMay 2 2018, 5:20 PM
Harbormaster completed remote builds in B16398: Diff 42069.May 2 2018, 5:20 PM
jhb accepted this revision.May 2 2018, 5:25 PM
jhb added inline comments.
sys/dev/pci/vga_pci.c
290

Cosmetic nits. Existing style in this file is to use 'error' instead of 'rc' and to not do assignments inside of conditionals, so:

int error;

error = bus_generic_detach(dev);
if (error == 0)
    errror = device_delete_children(dev);
return (error);
This revision is now accepted and ready to land.May 2 2018, 5:25 PM
rgrimes added a subscriber: rgrimes.May 2 2018, 5:31 PM

How do you trigger a call to this DEVMETHOD?

imp added a comment.May 2 2018, 5:36 PM
In D15269#321869, @rgrimes wrote:

How do you trigger a call to this DEVMETHOD?

  1. devctl detatch vga0
grehan updated this revision to Diff 42072.May 2 2018, 5:47 PM

Update style as per jhb.

This revision now requires review to proceed.May 2 2018, 5:47 PM
Harbormaster completed remote builds in B16399: Diff 42072.May 2 2018, 5:47 PM
imp accepted this revision.May 2 2018, 5:51 PM
This revision is now accepted and ready to land.May 2 2018, 5:51 PM
rgrimes accepted this revision.May 2 2018, 6:15 PM
Closed by commit rS333230: Allow PCI VGA devices to be detached. (authored by grehan). · Explain WhyMay 3 2018, 10:51 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
dev/
pci/
12 lines

Diff 42072

View Options

sys/dev/pci/vga_pci.c

Loading...