Page MenuHomeFreeBSD

Allow PCI VGA devices to be detached.
ClosedPublic

Authored by grehan on May 2 2018, 5:20 PM.

Details

Summary

GPUs often have VGA PCI device IDs and are probed/attached
by the VGA driver. Allow them to be detached so they can
be presented as passthru devices to VM guests.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

grehan created this revision.May 2 2018, 5:20 PM
jhb accepted this revision.May 2 2018, 5:25 PM
jhb added inline comments.
sys/dev/pci/vga_pci.c
290 ↗(On Diff #42069)

Cosmetic nits. Existing style in this file is to use 'error' instead of 'rc' and to not do assignments inside of conditionals, so:

int error;

error = bus_generic_detach(dev);
if (error == 0)
    errror = device_delete_children(dev);
return (error);
This revision is now accepted and ready to land.May 2 2018, 5:25 PM
rgrimes added a subscriber: rgrimes.May 2 2018, 5:31 PM

How do you trigger a call to this DEVMETHOD?

imp added a comment.May 2 2018, 5:36 PM

How do you trigger a call to this DEVMETHOD?

  1. devctl detatch vga0
grehan updated this revision to Diff 42072.May 2 2018, 5:47 PM

Update style as per jhb.

This revision now requires review to proceed.May 2 2018, 5:47 PM
imp accepted this revision.May 2 2018, 5:51 PM
This revision is now accepted and ready to land.May 2 2018, 5:51 PM
rgrimes accepted this revision.May 2 2018, 6:15 PM
This revision was automatically updated to reflect the committed changes.