iflib: remove unused brscp pointer from iflib_queues_alloc
ClosedPublic
Actions

Authored by jacob.e.keller_intel.com on May 3 2018, 9:25 PM.

Details

Reviewers

shurd
scottl
gallatin
kmacy
sbruno

Commits

rS333253: iflib: remove unused brscp pointer from iflib_queues_alloc

Summary

This pointer was no longer written to as of commit 303d1e3a0eed ("IFLIB
updates - unconditionally enable BUS_DMA on non-x86 architectures",
2017-03-13, github mirror).

Since nothing writes to the variable, remove it.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16415
Build 16336: arc lint + arc unit

Event Timeline

jacob.e.keller_intel.com created this revision.May 3 2018, 9:25 PM

Herald added a subscriber: ae. · View Herald TranscriptMay 3 2018, 9:25 PM

Harbormaster completed remote builds in B16415: Diff 42105.May 3 2018, 9:25 PM

jacob.e.keller_intel.com added a child revision: D15285: iflib: fix invalid free during queue allocation failure.May 3 2018, 9:43 PM

Seems fine to me.

This revision is now accepted and ready to land.May 3 2018, 11:09 PM

kmacy accepted this revision.May 4 2018, 7:33 AM

gallatin accepted this revision.May 4 2018, 12:33 PM

Closed by commit rS333253: iflib: remove unused brscp pointer from iflib_queues_alloc (authored by shurd). · Explain WhyMay 4 2018, 3:11 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptMay 4 2018, 3:11 PM

Revision Contents
Changeset List

Path

Size

sys/

net/

iflib.c

4 lines

Diff 42105

View Options

iflib: remove unused brscp pointer from iflib_queues_allocClosedPublicActions