Allow NIC drivers to sleep rather than busy wait
ClosedPublic
Actions

Authored by kmacy on Apr 6 2018, 1:04 AM.

Details

Reviewers

Commits

rS333218: Allow iflib NIC drivers to sleep rather than busy wait

Summary

Since the move to SMP NIC driver locking has had to go through serious contortions using mtx around long running hardware operations. This moves iflib past that.

This change depends on D14967, D14969, and D14982

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 16406

Event Timeline

kmacy created this revision.Apr 6 2018, 1:04 AM

Herald added subscribers: ae, imp. · View Herald TranscriptApr 6 2018, 1:04 AM

Harbormaster completed remote builds in B16008: Diff 41163.Apr 6 2018, 1:04 AM

kmacy added a child revision: D14984: Sleep rather than spin in e1000 when doing long running config operations.Apr 6 2018, 1:07 AM

kmacy added a subscriber: sbruno.Apr 6 2018, 1:24 AM

shurd added inline comments.Apr 9 2018, 4:36 PM

sys/net/iflib.c
2156	errant whitespace?
2161	IFC_DO_WATCHDOG is never cleared...
3738	Shouldn't this test be protected by the lock as well?
4434	errant whitespace?

This patch doesn't apply after the dependencies are applied.

This revision now requires changes to proceed.Apr 9 2018, 5:07 PM

rebase

Harbormaster completed remote builds in B16406: Diff 42083.May 3 2018, 1:46 AM

This revision was not accepted when it landed; it landed in state Needs Review.May 3 2018, 5:02 PM

Closed by commit rS333218: Allow iflib NIC drivers to sleep rather than busy wait (authored by shurd). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

net/

iflib.h

6 lines

iflib.c

28 lines

Diff 42083

View Options

sys/net/iflib.h