Allow PCI VGA devices to be detached.
ClosedPublic
Actions

Authored by grehan on May 2 2018, 5:20 PM.

Details

Reviewers

jhb
imp
rgrimes

Group Reviewers

bhyve

Commits

rS333230: Allow PCI VGA devices to be detached.

Summary

GPUs often have VGA PCI device IDs and are probed/attached
by the VGA driver. Allow them to be detached so they can
be presented as passthru devices to VM guests.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16399
Build 16324: arc lint + arc unit

Event Timeline

grehan created this revision.May 2 2018, 5:20 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 2 2018, 5:20 PM

Harbormaster completed remote builds in B16398: Diff 42069.May 2 2018, 5:20 PM

jhb accepted this revision.May 2 2018, 5:25 PM

jhb added inline comments.

sys/dev/pci/vga_pci.c
290	Cosmetic nits. Existing style in this file is to use 'error' instead of 'rc' and to not do assignments inside of conditionals, so: int error; error = bus_generic_detach(dev); if (error == 0) errror = device_delete_children(dev); return (error);