This code based geom_map.c. This function enable by kernel
option GEOM_FLASHMAP_ADJUST_BORDER.
Details
Diff Detail
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 15954 Build 15946: arc lint + arc unit
Event Timeline
Hi,
Small cosmetic changes are required.
But I don't get idea why this marker lookup can't be done by flash_slicer code.
Could you please clarify benefit?
Thank you!
sys/geom/geom_flashmap.c | ||
---|---|---|
216–218 | add declaration at top of file? | |
222 | 128 bytes on stack is not good, please malloc/free it. | |
258 | bootverbose? | |
263 | please prefix g_flashmap_% |
If kernel configuration change and kernel size make big then std partition information is missing. In this case boot stop at mountroot. It's inconvenient. Non-FDT slicer geom_map have same function. I think more better this function set by FDT information than kernel option. But I don't know FDT access in geom code.
I think dts must not have kernel size because of it's change kernel configuration. This code separate to kernel and rootfs from firmware partition.
This is dts entory.
firmware: partition@50000 { label = "firmware"; reg = <0x00050000 0x003b0000>; read-only; };
This is boot log.
cfid0: slice 00050000-0015ffff: firmware (1087KB)
cfid0: slice 00160000-003fffff: rootfs (2687KB)
I checked dev/bhnd/cores/chipc/chipc_slicer.c. This code on CFI or SPI low level driver code. General CFI and SPI driver code use not only u-boot. I think good that is not change CFE and SPI driver code. Also I think geom_flashmap change is more small side effect than flash_slicer change.