Page MenuHomeFreeBSD

Add geom consumer parapater to slicer and rootfs search method fdt slicer like OpenWRT.
AbandonedPublic

Authored by yamori813_yahoo.co.jp on Dec 5 2019, 5:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 12 2023, 9:24 PM
Unknown Object (File)
Nov 23 2023, 12:06 AM
Unknown Object (File)
Oct 3 2023, 9:36 PM
Unknown Object (File)
Sep 6 2023, 6:47 AM
Unknown Object (File)
Aug 14 2023, 10:02 PM
Unknown Object (File)
Aug 14 2023, 11:29 AM
Unknown Object (File)
Aug 11 2023, 4:29 PM
Unknown Object (File)
Jun 27 2023, 7:43 AM
Subscribers
None

Details

Summary

This is reimplimentation of D13648

Test Plan

CFI and SPI flash on sys/mips/medeatek

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 27968
Build 26134: arc lint + arc unit

Event Timeline

this is dts setting.

firmware: partition@50000 {
        compatible = "denx,uimage";
        label = "firmware";
        reg = <0x00050000 0x00390000>;
        read-only;
};
ian requested changes to this revision.Dec 5 2019, 4:16 PM

This change is unacceptable. Child nodes of a flash device which represent partitions must not have a compatible property, it is forbidden by the bindings document. I believe the correct way to do this is that there must be a child node with a compatible of "fixed-partitions", then within that node, there can be child nodes describing partitions which have compatible properties on them. Right now, fdt_slicer doesn't handle that kind of node structure.

Adding the checks for denx,uimage into the slicer in a way that requires it to do IO doesn't seem correct either. The fdt_slicer is for creating partitions that require out-of-band metadata (fdt data) to describe. Finding partitions by reading the content of the media seems like it should be handled the same way as other partitioning schemes that read media and create partitions from what they find (gpt, mbr, etc).

This revision now requires changes to proceed.Dec 5 2019, 4:16 PM
In D22685#496456, @ian wrote:

This change is unacceptable. Child nodes of a flash device which represent partitions must not have a compatible property, it is forbidden by the bindings document. I believe the correct way to do this is that there must be a child node with a compatible of "fixed-partitions", then within that node, there can be child nodes describing partitions which have compatible properties on them. Right now, fdt_slicer doesn't handle that kind of node structure.

Adding the checks for denx,uimage into the slicer in a way that requires it to do IO doesn't seem correct either. The fdt_slicer is for creating partitions that require out-of-band metadata (fdt data) to describe. Finding partitions by reading the content of the media seems like it should be handled the same way as other partitioning schemes that read media and create partitions from what they find (gpt, mbr, etc).

I want same function of geom_map. How do I modify ?