Static analysis: Improve DAD deletion code
ClosedPublic
Actions

Authored by jtl on May 26 2017, 5:06 PM.

Details

Reviewers

hrs
ae
vangyzen

Group Reviewers

network

Commits

rS331488: This change adds a flag to the DAD entry to indicate whether it is

Summary

I ran clang's static analyzer over the kernel sources. It identified some concerns with the way DAD entries were removed from the DAD queue.

This change adds a flag to the DAD entry to indicate whether it is currently on the queue. This prevents accidentally doubly-removing a DAD entry from the queue, while also simplifying some of the logic in nd6_dad_stop().

Sponsored by: Netflix
MFC after: 2 weeks

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jtl created this revision.May 26 2017, 5:06 PM

Herald added subscribers: ae, imp. · View Herald TranscriptMay 26 2017, 5:06 PM

jtl mentioned this in D10936: Fix static analysis errors in IPv6 code.May 26 2017, 5:08 PM

hiren added a reviewer: hrs.May 26 2017, 10:12 PM

Can someone please review this? This has been outstanding for a while...

Herald added a subscriber: vangyzen. · View Herald TranscriptMar 22 2018, 10:56 AM

ae accepted this revision.Mar 22 2018, 11:17 AM

This revision is now accepted and ready to land.Mar 22 2018, 11:17 AM

hrs accepted this revision.Mar 22 2018, 3:35 PM

vangyzen accepted this revision.Mar 22 2018, 3:50 PM

vangyzen added inline comments.

sys/netinet6/nd6_nbr.c
1149 ↗	(On Diff #28874)	I don't like the refcount asymmetry between add() and del(), but add() is only called in one place, and this predates your change, so I'm just complaining in your general direction. :)
1307 ↗	(On Diff #28874)	At first, I didn't understand whose reference this is releasing. Maybe it's worth a comment, like /* Release this function's reference, acquired by nd6_dad_find(). */ On the other hand, anyone who works in this code will need to understand this behavior, so maybe the comment is superfluous. Your call.