Page MenuHomeFreeBSD

Fix static analysis errors in IPv6 code
AbandonedPublic

Authored by jtl on May 26 2017, 3:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 29 2024, 7:20 PM
Unknown Object (File)
Dec 16 2023, 8:34 PM
Unknown Object (File)
Nov 29 2023, 3:22 AM
Unknown Object (File)
Nov 24 2023, 1:15 AM
Unknown Object (File)
Nov 23 2023, 5:15 PM
Unknown Object (File)
Nov 23 2023, 5:06 PM
Unknown Object (File)
Sep 22 2023, 2:01 PM
Unknown Object (File)
Mar 3 2023, 4:03 PM
Subscribers

Details

Reviewers
bz
Group Reviewers
network
Summary

I ran clang's static analyzer over the kernel sources. I've fixed a number of the errors in the IPv6 code.

These run the range from relatively important (could cause a kernel crash) to fairly minor (variables that are set but not used).

Sponsored by: Netflix
MFC after: 2 weeks

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

bz requested changes to this revision.May 26 2017, 3:17 PM
bz added a subscriber: bz.

Can you make a first patch which is just "Remove unused variables"? That way removing the functional changes is a lot easier.
Also when you have to go back in 5 years and wonder what this all was.

This revision now requires changes to proceed.May 26 2017, 3:17 PM

At @bz's request, I opened D10940, D10941, D10942, and D10943 for the component parts of this revision.