Page MenuHomeFreeBSD

Fix static analysis errors in IPv6 code
AbandonedPublic

Authored by jtl on May 26 2017, 3:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, May 11, 9:32 PM
Unknown Object (File)
Apr 21 2025, 1:00 PM
Unknown Object (File)
Apr 17 2025, 7:34 AM
Unknown Object (File)
Apr 14 2025, 5:00 AM
Unknown Object (File)
Feb 16 2025, 5:45 AM
Unknown Object (File)
Jan 12 2025, 4:24 AM
Unknown Object (File)
Dec 29 2024, 12:36 AM
Unknown Object (File)
Dec 27 2024, 6:16 PM
Subscribers

Details

Reviewers
bz
Group Reviewers
network
Summary

I ran clang's static analyzer over the kernel sources. I've fixed a number of the errors in the IPv6 code.

These run the range from relatively important (could cause a kernel crash) to fairly minor (variables that are set but not used).

Sponsored by: Netflix
MFC after: 2 weeks

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

bz requested changes to this revision.May 26 2017, 3:17 PM
bz added a subscriber: bz.

Can you make a first patch which is just "Remove unused variables"? That way removing the functional changes is a lot easier.
Also when you have to go back in 5 years and wonder what this all was.

This revision now requires changes to proceed.May 26 2017, 3:17 PM

At @bz's request, I opened D10940, D10941, D10942, and D10943 for the component parts of this revision.