Page MenuHomeFreeBSD

Fix static analysis errors in IPv6 code
AbandonedPublic

Authored by jtl on May 26 2017, 3:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 13, 5:26 PM
Unknown Object (File)
Wed, May 13, 5:26 PM
Unknown Object (File)
Mon, May 11, 10:48 PM
Unknown Object (File)
Sun, May 10, 12:32 AM
Unknown Object (File)
Sat, May 9, 9:35 PM
Unknown Object (File)
Sat, May 2, 3:05 PM
Unknown Object (File)
Thu, Apr 30, 7:55 AM
Unknown Object (File)
Thu, Apr 30, 6:59 AM
Subscribers

Details

Reviewers
bz
Group Reviewers
network
Summary

I ran clang's static analyzer over the kernel sources. I've fixed a number of the errors in the IPv6 code.

These run the range from relatively important (could cause a kernel crash) to fairly minor (variables that are set but not used).

Sponsored by: Netflix
MFC after: 2 weeks

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

bz requested changes to this revision.May 26 2017, 3:17 PM
bz added a subscriber: bz.

Can you make a first patch which is just "Remove unused variables"? That way removing the functional changes is a lot easier.
Also when you have to go back in 5 years and wonder what this all was.

This revision now requires changes to proceed.May 26 2017, 3:17 PM

At @bz's request, I opened D10940, D10941, D10942, and D10943 for the component parts of this revision.