Page MenuHomeFreeBSD
Differential D10940

Static analysis: Remove unused variables in IPv6 code
ClosedPublic
Actions

Authored by jtl on May 26 2017, 4:43 PM.
Tags
None
Referenced Files
F166949183: D10940.id.diff
Tue, Aug 18, 1:10 AM
F166914304: D10940.id28871.diff
Mon, Aug 17, 5:56 PM
Unknown Object (File)
Sun, Aug 16, 8:56 PM
Unknown Object (File)
Sun, Aug 16, 7:38 PM
Unknown Object (File)
Sun, Aug 16, 7:16 PM
Unknown Object (File)
Sat, Aug 15, 9:28 PM
Unknown Object (File)
Sat, Aug 15, 9:26 PM
Unknown Object (File)
Sat, Aug 15, 7:58 PM
View All Files
Subscribers
ae
bz
imp
vangyzen

Details

Reviewers
bz
Group Reviewers
network
Commits
rS331484: Remove some unneccessary variable sets in IPv6 code, as detected by
Summary

I ran clang's static analyzer over the kernel sources. It identified a number of places where variables are set, but not used. This change cleans up a number of these places.

Sponsored by: Netflix
MFC after: 2 weeks

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jtl created this revision.May 26 2017, 4:43 PM
Herald added subscribers: ae, imp. · View Herald TranscriptMay 26 2017, 4:43 PM
jtl mentioned this in D10936: Fix static analysis errors in IPv6 code.May 26 2017, 5:08 PM
jtl updated this revision to Diff 40593.Mar 22 2018, 10:54 AM

Most of these changes have been committed by now. Updating diff with a few remaining bits.

Herald added a subscriber: vangyzen. · View Herald TranscriptMar 22 2018, 10:54 AM
Harbormaster completed remote builds in B15713: Diff 40593.Mar 22 2018, 10:54 AM
jtl added a comment.Mar 22 2018, 10:56 AM

Starting the (approx.) 48-hour countdown timer until commit.

bz accepted this revision.Mar 22 2018, 2:14 PM
bz added a subscriber: bz.

Seems good to me.

This revision is now accepted and ready to land.Mar 22 2018, 2:14 PM
Closed by commit rS331484: Remove some unneccessary variable sets in IPv6 code, as detected by (authored by jtl). · Explain WhyMar 24 2018, 12:43 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
netinet6/
2 lines
1 line
2 lines
2 lines

Diff 40685

View Options

head/sys/netinet6/dest6.c

Loading...
View Options

head/sys/netinet6/icmp6.c

Loading...
View Options

head/sys/netinet6/ip6_output.c

Loading...
View Options

head/sys/netinet6/udp6_usrreq.c

Loading...