Use vm_page_unwire_noq() in some pmap code.
ClosedPublic
Actions

Authored by markj on Feb 8 2018, 4:44 PM.

Details

Reviewers

alc
kib
jeff

Commits

rS329023: Use vm_page_unwire_noq() instead of directly modifying page wire counts.

Summary

The use of atomic_subtract_rel_int() in the riscv and arm64 pmaps seems
to be bogus: it was copied from amd64 (see r321847), and occurs *after* the
pmap_invalidate_page() call that the comment is referring to.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14872
Build 14985: arc lint + arc unit

Event Timeline

markj created this revision.Feb 8 2018, 4:44 PM

Herald added subscribers: emaste, andrew. · View Herald TranscriptFeb 8 2018, 4:44 PM

markj edited the summary of this revision. (Show Details)Feb 8 2018, 4:46 PM

markj added reviewers: alc, kib, jeff.

kib accepted this revision.Feb 8 2018, 5:34 PM

This revision is now accepted and ready to land.Feb 8 2018, 5:34 PM

alc accepted this revision.Feb 8 2018, 6:18 PM

Closed by commit rS329023: Use vm_page_unwire_noq() instead of directly modifying page wire counts. (authored by markj). · Explain WhyFeb 8 2018, 7:29 PM

This revision was automatically updated to reflect the committed changes.

Herald added subscribers: jhibbits, imp. · View Herald TranscriptFeb 8 2018, 7:29 PM

Revision Contents
Changeset List

Path

Size

sys/

amd64/

pmap.c

15 lines

arm64/

pmap.c

22 lines

i386/

pmap.c

3 lines

mips/

pmap.c

6 lines

riscv/

pmap.c

13 lines

Diff 39044

View Options

sys/amd64/amd64/pmap.c

View Options

sys/arm64/arm64/pmap.c

View Options

sys/i386/i386/pmap.c

View Options

sys/mips/mips/pmap.c

View Options

Use vm_page_unwire_noq() in some pmap code.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 39044

sys/amd64/amd64/pmap.c

sys/arm64/arm64/pmap.c

sys/i386/i386/pmap.c

sys/mips/mips/pmap.c

sys/riscv/riscv/pmap.c

Use vm_page_unwire_noq() in some pmap code.
ClosedPublic
Actions

Revision Contents
Changeset List