Allow CROSS_TOOLCHAIN to be a path to a file.
ClosedPublic
Actions

Authored by brooks on Feb 2 2018, 10:40 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Jul 5, 9:25 PM

	Unknown Object (File)
	Jun 1 2026, 4:07 PM

	Unknown Object (File)
	Jun 1 2026, 11:54 AM

	Unknown Object (File)
	Jun 1 2026, 3:29 AM

	Unknown Object (File)
	May 30 2026, 5:02 AM

	Unknown Object (File)
	May 8 2026, 7:21 PM

	Unknown Object (File)
	May 2 2026, 10:30 AM

	Unknown Object (File)
	Apr 29 2026, 3:02 PM

View All Files

Subscribers

imp

Details

Reviewers

bapt
bdrewery
jhb
emaste

Commits

rS329993: Allow CROSS_TOOLCHAIN to be a path to a file.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14750
Build 14871: arc lint + arc unit

Event Timeline

brooks created this revision.Feb 2 2018, 10:40 PM

Harbormaster completed remote builds in B14750: Diff 38799.Feb 2 2018, 10:40 PM

poke

This revision was not accepted when it landed; it landed in state Needs Review.Feb 25 2018, 8:21 PM

Closed by commit rS329993: Allow CROSS_TOOLCHAIN to be a path to a file. (authored by brooks). · Explain Why

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptFeb 25 2018, 8:21 PM

emaste added inline comments.Feb 25 2018, 10:10 PM

head/Makefile.inc1
64 ↗	(On Diff #39717)	Maybe `CROSS_TOOLCHAIN ${CROSS_TOOLCHAIN} not found`? My thought is that someone may find instructions to run e.g. `make CROSS_TOOLCHAIN=powerpc64-gcc TARGET=powerpc TARGET_ARCH=powerpc64 buildworld`, and if it's not installed reporting that it's invalid could be confusing.

jhb added inline comments.Feb 26 2018, 5:51 PM

head/Makefile.inc1
64 ↗	(On Diff #39717)	+1 on Ed's suggestion (a fan of the overall change though)

Revision Contents
Changeset List

Path

Size

Makefile.inc1

6 lines

Diff 38799

View Options

Allow CROSS_TOOLCHAIN to be a path to a file.ClosedPublicActions