Page MenuHomeFreeBSD
Differential D14129

Export tcp_always_keepalive for use by the Chelsio TOM module.
ClosedPublic
Actions

Authored by jhb on Jan 30 2018, 1:22 AM.
Tags
None
Referenced Files
F170679851: D14129.id38691.diff
Sun, Sep 6, 12:04 AM
F170677380: D14129.id.diff
Sat, Sep 5, 11:42 PM
Unknown Object (File)
Sat, Sep 5, 6:21 PM
Unknown Object (File)
Sat, Sep 5, 5:05 PM
Unknown Object (File)
Sat, Sep 5, 12:08 AM
Unknown Object (File)
Thu, Sep 3, 2:25 PM
Unknown Object (File)
Wed, Sep 2, 4:46 PM
Unknown Object (File)
Wed, Sep 2, 12:59 PM
View All Files
Subscribers
ae
bz
imp
transport

Details

Reviewers
np
emaste
bz
Group Reviewers
transport
Commits
rS328608: Export tcp_always_keepalive for use by the Chelsio TOM module.
Summary

This used to work by accident with ld.bfd even though always_keepalive
was marked as static. LLD honors static more correctly, so export this
variable properly (including moving it into the tcp_* namespace).

Test Plan
  • try to kldload t4_tom.ko on a LLD-linked kernel

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 14667
Build 14796: arc lint + arc unit

Event Timeline

jhb created this revision.Jan 30 2018, 1:22 AM
Harbormaster completed remote builds in B14667: Diff 38656.Jan 30 2018, 1:22 AM
Herald added a reviewer: transport. · View Herald TranscriptJan 30 2018, 1:22 AM
Herald added a reviewer: transport. · View Herald Transcript
Herald added a subscriber: ae. · View Herald Transcript
bz accepted this revision.Jan 30 2018, 12:00 PM
bz added a subscriber: bz.

LGTM (not checked but assume you caught all places)

This revision is now accepted and ready to land.Jan 30 2018, 12:00 PM
emaste accepted this revision.Jan 30 2018, 12:12 PM
Closed by commit rS328608: Export tcp_always_keepalive for use by the Chelsio TOM module. (authored by jhb). · Explain WhyJan 30 2018, 11:01 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptJan 30 2018, 11:01 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
cxgbe/
tom/
5 lines
netinet/
1 line
7 lines

Diff 38656

View Options

sys/dev/cxgbe/tom/t4_tom.c

Loading...
View Options

sys/netinet/tcp_timer.h

Loading...
View Options

sys/netinet/tcp_timer.c

Loading...