Page MenuHomeFreeBSD

Allow ALSA aliases in the Qt5 sound devices list. Patch by Stephen Hurd.
ClosedPublic

Authored by adridg on Jan 19 2018, 10:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 19, 10:36 AM
Unknown Object (File)
Sun, Mar 10, 10:53 AM
Unknown Object (File)
Sun, Mar 10, 10:53 AM
Unknown Object (File)
Sun, Mar 10, 10:53 AM
Unknown Object (File)
Sun, Mar 10, 10:53 AM
Unknown Object (File)
Sun, Mar 10, 10:53 AM
Unknown Object (File)
Sun, Mar 10, 10:28 AM
Unknown Object (File)
Mon, Mar 4, 7:47 PM
Subscribers

Details

Summary

Build on amd64, run test application from PR208570.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 14495
Build 14637: arc lint + arc unit

Event Timeline

multimedia/qt5-multimedia/files/patch-src_plugins_alsa_qalsaaudiodeviceinfo.cpp
2

^ this belongs into the 'Submitted by'

7

^ This does not really help to understand what the patch does :)

Stephen's first message in the PR is probably a bit more descriptive:

When using ALSA with FreeBSD, the direct snd_device instances are not available, only plugin devices and "default".  For programs which use QAudio, this means there are *no* devices enumerated using QAudio::availableDevices().

The attached patch adds the aliases to the available device list.

Fix patch so it actually applies.

Looks good, but please include a short description like Stephens' comment atop the patch.

This revision is now accepted and ready to land.Jan 19 2018, 11:31 PM
This revision was automatically updated to reflect the committed changes.