Page MenuHomeFreeBSD

Allow ALSA aliases in the Qt5 sound devices list. Patch by Stephen Hurd.
ClosedPublic

Authored by adridg on Jan 19 2018, 10:40 PM.

Details

Summary

Build on amd64, run test application from PR208570.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14493
Build 14635: arc lint + arc unit

Event Timeline

adridg created this revision.Jan 19 2018, 10:40 PM
adridg updated this revision to Diff 38228.Jan 19 2018, 10:41 PM

Forgot portrevision bump.

tcberner added inline comments.Jan 19 2018, 10:51 PM
multimedia/qt5-multimedia/files/patch-src_plugins_alsa_qalsaaudiodeviceinfo.cpp
2

^ this belongs into the 'Submitted by'

7

^ This does not really help to understand what the patch does :)

Stephen's first message in the PR is probably a bit more descriptive:

When using ALSA with FreeBSD, the direct snd_device instances are not available, only plugin devices and "default".  For programs which use QAudio, this means there are *no* devices enumerated using QAudio::availableDevices().

The attached patch adds the aliases to the available device list.
adridg updated this revision to Diff 38232.Jan 19 2018, 11:00 PM

Fix patch so it actually applies.

tcberner accepted this revision.Jan 19 2018, 11:31 PM

Looks good, but please include a short description like Stephens' comment atop the patch.

This revision is now accepted and ready to land.Jan 19 2018, 11:31 PM
adridg marked 2 inline comments as done.Jan 20 2018, 12:42 PM
This revision was automatically updated to reflect the committed changes.