- poudriere testport 10/11 i386/amd64 (both ports, default python flavor and py36)
- portlint: warnings about missing LICENSE and DISTVERSION set elsewhere
Details
Details
- Reviewers
tcberner - Group Reviewers
Python kde O5: Ports Framework (Owns No Changed Paths) portmgr - Commits
- rP458563: New ports: www/py-qt5-webchannel and www/py-qt5-webengine
Diff Detail
Diff Detail
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 14114 Build 14289: arc lint + arc unit
Event Timeline
Comment Actions
I think this is one of the few times where I think one port more is better ^^ -- I would split the WebChannel part out of it, so that people that want to use WebChannel are not forced to have WebEngine installed.
Comment Actions
As @tcberner says, it's probably best to try to split this into two, webchannel and webengine, to match the existing lightweight(-ish) qt5-webchannel and the heavyweight qt5-webengine.
| Mk/Uses/pyqt.mk | ||
|---|---|---|
| 129 | This change looks funny, but it is correct: there is a superfluous space before two tabs in this line. | |
Comment Actions
If this goes in before the python flavors thing, could you poke me, like on irc so that I do check it does not break some magic I added here and there ?
Comment Actions
No problem. I could wait until you are ready with the python flavors. Do you have an approximate time that will be ready?
Comment Actions
The patch is ready, but I am waiting for poudriere 3.2 to be released, and some doc to be written. So don't wait on my account, just ping me :-)
Comment Actions
Address latest comments and update for flavors
Updating D12964: New port, www/py-qt5-webengine: Python bindings for the Qt5 toolkit,
QtWebEngine module
Comment Actions
- Add webchannel_run to USE_PYQT in www/py-qt5-webengine
- Update after r458033
Updating D12964: New port, www/py-qt5-webengine: Python bindings for the Qt5 toolkit,
QtWebEngine module
Comment Actions
You should probably bump the revision of the metaport devel/py-qt5 as it has two new run-depends.
| devel/py-qt5/Makefile | ||
|---|---|---|
| 15 ↗ | (On Diff #37528) | I think this is equivalent to ${_USE_PYQT_ALL}. But I guess this is more readable ^^. |
| devel/py-qt5/Makefile | ||
|---|---|---|
| 15 ↗ | (On Diff #37528) | But options are parsed before USES, so _USE_PYQT_ALL does not exist at that point. |
Comment Actions
- Patch configure.py to add printsupport to QtWebEngineWidgets
- www/py-qt5-webengine: Update pkg-plist for --enable QtWebEngineCore
Comment Actions
After the changes, I think it's good to go :)
Thanks for working on it.
| devel/py-qt5-core/files/patch-configure.py | ||
|---|---|---|
| 9 ↗ | (On Diff #37684) | ^ you should mention the webengine part too |
| www/py-qt5-webchannel/Makefile | ||
| 15 | O would prefer: | |
| www/py-qt5-webengine/Makefile | ||
| 17 | ^ seem to be a few to many whitespaces bewteen widgets and qmake_build | |