- poudriere testport 10/11 i386/amd64 (both ports, default python flavor and py36)
- portlint: warnings about missing LICENSE and DISTVERSION set elsewhere
I think this is one of the few times where I think one port more is better ^^ -- I would split the WebChannel part out of it, so that people that want to use WebChannel are not forced to have WebEngine installed.
As @tcberner says, it's probably best to try to split this into two, webchannel and webengine, to match the existing lightweight(-ish) qt5-webchannel and the heavyweight qt5-webengine.
|126 ↗||(On Diff #34810)|
This change looks funny, but it is correct: there is a superfluous space before two tabs in this line.
After the changes, I think it's good to go :)
Thanks for working on it.
|9 ↗||(On Diff #37684)|
^ you should mention the webengine part too
|14 ↗||(On Diff #37684)|
O would prefer:
|16 ↗||(On Diff #37684)|
^ seem to be a few to many whitespaces bewteen widgets and qmake_build