Differential D13573

recognize a pending virtual interrupt while emulating halt instruction
ClosedPublic
Actions

Authored by tychon on Dec 21 2017, 3:40 PM.

Tags

None

Referenced Files

	F169042466: D13573.id36872.diff
	Mon, Aug 31, 5:34 AM

	F169042196: D13573.id36864.diff
	Mon, Aug 31, 5:33 AM

	Unknown Object (File)
	Sun, Aug 30, 1:11 PM

	Unknown Object (File)
	Fri, Aug 28, 1:12 PM

	Unknown Object (File)
	Fri, Aug 28, 9:31 AM

	Unknown Object (File)
	Thu, Aug 27, 3:27 PM

	Unknown Object (File)
	Thu, Aug 27, 2:22 PM

	Unknown Object (File)
	Thu, Aug 27, 2:18 PM

Subscribers

Details

Reviewers

grehan
rgrimes

Group Reviewers

Commits

rS328011: Provide some mitigation against CVE-2017-5715 by clearing registers
rS327065: Recognize a pending virtual interrupt while emulating the halt instruction.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

tychon created this revision.Dec 21 2017, 3:40 PM

rgrimes added a subscriber: rgrimes.Dec 21 2017, 4:04 PM

rgrimes added inline comments.Dec 21 2017, 4:11 PM

sys/amd64/vmm/intel/vmx.c
3190 ↗	(On Diff #36864)	Do we need to do some .h work, seems you use this magic constant 0xf0 twice here, for me that means it probably should be a #define that is descriptive of what bits are being masked?

Replace magic constants with #define, within the function, to clarify usage.

grehan accepted this revision.Dec 21 2017, 6:10 PM

This revision is now accepted and ready to land.Dec 21 2017, 6:10 PM

rgrimes accepted this revision.Dec 21 2017, 6:14 PM

rgrimes added a reviewer: rgrimes.

Closed by commit rS327065: Recognize a pending virtual interrupt while emulating the halt instruction. (authored by tychon). · Explain WhyDec 21 2017, 6:30 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptDec 21 2017, 6:30 PM

emaste mentioned this in D13919: mitigate against CVE-2017-5715 by clearing registers upon returning from the guest.Jan 15 2018, 8:21 PM

kmacy mentioned this in D14382: Fix bhyve w/ INVARIANTS post D13573.Feb 15 2018, 3:41 AM

tychon mentioned this in D14548: Fix a lock recursion introduced in r327065..Feb 28 2018, 7:44 PM

Revision Contents
Changeset List

Path

Size

amd64/

vmm/

intel/

28 lines

Diff 36870

amd64/vmm/intel/vmx.c

Loading...