science/paraview: Unbreak build
PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216634
Approved by: jrm (mentor) or wen (mentor)
Differential to be added to commit log
Details
Details
- Reviewers
jrm koobs - Commits
- rP456189: science/paraview: Unbreak build with clang 4.0
portlint -C: Clean
Poudriere test running now on {10.3,11.1}-{amd64,i386}
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| science/paraview/Makefile | ||
|---|---|---|
| 32 ↗ | (On Diff #36504) | Should this have the flavor-foo for the python version? Should this be done now or should the focus be only on fixing the build issue? |
| 87–100 ↗ | (On Diff #36504) | For future work, these could be converted to option helpers. |
| science/paraview/files/patch-Plugins_CDIReader_cdilib.c | ||
| 1 ↗ | (On Diff #36504) | It looks like just the timestamp changed here, so this change could/should be left out? |
| science/paraview/Makefile | ||
|---|---|---|
| 32 ↗ | (On Diff #36504) | It must, yes. Add @${PY_FLAVOR}. |
Comment Actions
Also, RUN_DEPENDS= ... ${PYTHON_SITELIBDIR}/matplotlib/pyplot.py:math/py-matplotlib@${PY_FLAVOR}
Comment Actions
I'm getting swamped again this morning, so I'll get back to these later when I can focus again...
Comment Actions
Haven't heard from the maintainer yet. He submitted part of the patch on Aprll 6th and that's the last anyone heard from him. Should I try to reach out to him in case he didn't see the bugtracker updates?
Comment Actions
The two week timeout could probably be considered to have started after Tobias's comment in August. You could 1) commit it noting the maintainer timeout, 2) confirm with portmgr that the timeout has been reached then commit it, or 3) contact the maintainer. In case of 3) you should wait two weeks.
Comment Actions
I think 4 months without a response to Tobias is enough. Just wanted to know if there are any strict rules about this situation. I'm going to let the last of 4 poudriere builds finish and then I'll do the commit assuming it succeeds.